Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 315593004: Merge 274068 "Always use the source channel layout with AudioBuf..." (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
Reviewers:
Dale Curtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Merge 274068 "Always use the source channel layout with AudioBuf..." > Always use the source channel layout with AudioBufferConverter. > > There are no web sites currently using this feature, but it causes > all multichannel users to waste resources unnecessarily upmixing, > generating, and transferring empty channel data. > > Further this breaks fancy OSX multichannel users which have non > standard channel layouts. Mostly because we don't want to deal > with the plethora of ways OSX wants to map channels ourselves. > > Instead we can require that MSE users which want to change channel > counts, must specify the maximum number of channels in the first > initialization segment. > > This also fixes use cases where clients routed multichannel streams > into WebAudio for processing instead of actual playout. > > BUG=266674 > TEST=Only 2 channels are created for stereo sources when a 7.1 > device is connected. > > R=rileya@chromium.org, wolenetz@chromium.org > > Review URL: https://codereview.chromium.org/304233006 TBR=dalecurtis@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M media/filters/audio_renderer_impl.cc View 1 chunk +13 lines, -7 lines 0 comments Download
M media/filters/pipeline_integration_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
DaleCurtis
6 years, 6 months ago (2014-06-03 17:41:06 UTC) #1
DaleCurtis
6 years, 6 months ago (2014-06-03 17:41:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274566.

Powered by Google App Engine
This is Rietveld 408576698