Issue 315593002: Clusterfuzz identified overflow check needed in dehoisting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315593002: Clusterfuzz identified overflow check needed in dehoisting. (Closed)

Created:
6 years, 6 months ago by mvstanton

Modified:
6 years, 6 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Clusterfuzz identified overflow check needed in dehoisting. BUG=380092 R=danno@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21708

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -33 lines)			Patch
M	src/hydrogen-dehoist.cc	View	1	1 chunk	+13 lines, -5 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	1	5 chunks	+29 lines, -15 lines	0 comments	Download
A +	test/mjsunit/regress/regress-380092.js	View	1	1 chunk	+6 lines, -13 lines	0 comments	Download

Total messages: 5 (0 generated)

mvstanton

Hi Danno, here is the fix we discussed. Perhaps the overflow check is "overkill" in ...

6 years, 6 months ago (2014-06-03 12:29:27 UTC) #1

mvstanton

Hi Danno, Here is the revision we discussed, thx! --Michael

6 years, 6 months ago (2014-06-04 07:43:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r21708.