Issue 315583005: Pepper: Simplify error reporting in PnaclResources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315583005: Pepper: Simplify error reporting in PnaclResources. (Closed)

Created:
6 years, 6 months ago by teravest

Modified:
6 years, 6 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Simplify error reporting in PnaclResources. This change reduces the size of the public API for PnaclCoordinator and simplifies error reporting inside PnaclResources, making it easier to follow. BUG=239656 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274621

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -33 lines)			Patch
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h	View		2 chunks	+14 lines, -13 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc	View	1	3 chunks	+10 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_resources.h	View	1	2 chunks	+1 line, -6 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_resources.cc	View	1	3 chunks	+4 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm https://codereview.chromium.org/315583005/diff/1/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc File ppapi/native_client/src/trusted/plugin/pnacl_resources.cc (right): https://codereview.chromium.org/315583005/diff/1/ppapi/native_client/src/trusted/plugin/pnacl_resources.cc#newcode12 ppapi/native_client/src/trusted/plugin/pnacl_resources.cc:12: #include "ppapi/native_client/src/trusted/plugin/pnacl_coordinator.h" nit: don't need this anymore https://codereview.chromium.org/315583005/diff/1/ppapi/native_client/src/trusted/plugin/pnacl_resources.h ...

6 years, 6 months ago (2014-06-03 19:52:51 UTC) #2

teravest

6 years, 6 months ago (2014-06-03 21:02:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r274621 (presubmit successful).

Expand Messages | Collapse Messages