[Android] Fix SuggestionPopup width on device rotations

[Android] Fix SuggestionPopup width on device rotations

BUG=380224
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274753

[aurimas (slooooooooow), 2014-06-03 17:10:55]

Hey Ted,

Please take a look at this change.

This is a cleaner version of https://codereview.chromium.org/310733004/ by
sungmann.cho@navercorp.com

Aurimas

[aurimas (slooooooooow), 2014-06-03 17:35:16]

sungmann.cho@navercorp.com: please let me know if this addresses your bug and if
you have any additional comments about this change.

[Sungmann Cho, 2014-06-03 21:49:59]

https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
(right):

https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:58:
if (mSuggestionsPopup == null) return;
I think we need to check the visibility of |mSuggestionsPopup| here. Because
there is a case where |mSuggestionsPopup| is not null but it is not visible. For
instance, if we touch the out side of |mSuggestionsPopup| then it will disappear
but it will remain not null. So if we change the orientation of the device then
the invisible |mSuggestionsPopup| will be visible unintentionally.

[aurimas (slooooooooow), 2014-06-03 21:56:31]

https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
(right):

https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:58:
if (mSuggestionsPopup == null) return;
On 2014/06/03 21:50:00, Sungmann Cho wrote:
> I think we need to check the visibility of |mSuggestionsPopup| here. Because
> there is a case where |mSuggestionsPopup| is not null but it is not visible.
For
> instance, if we touch the out side of |mSuggestionsPopup| then it will
disappear
> but it will remain not null. So if we change the orientation of the device
then
> the invisible |mSuggestionsPopup| will be visible unintentionally.

Done.

[Sungmann Cho, 2014-06-03 22:05:23]

On 2014/06/03 21:56:31, aurimas wrote:
>
https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
> (right):
> 
>
https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:58:
> if (mSuggestionsPopup == null) return;
> On 2014/06/03 21:50:00, Sungmann Cho wrote:
> > I think we need to check the visibility of |mSuggestionsPopup| here. Because
> > there is a case where |mSuggestionsPopup| is not null but it is not visible.
> For
> > instance, if we touch the out side of |mSuggestionsPopup| then it will
> disappear
> > but it will remain not null. So if we change the orientation of the device
> then
> > the invisible |mSuggestionsPopup| will be visible unintentionally.
> 
> Done.

It works perfect for me! Thanks! :)

[Ted C, 2014-06-03 22:07:03]

On 2014/06/03 22:05:23, Sungmann Cho wrote:
> On 2014/06/03 21:56:31, aurimas wrote:
> >
>
https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
> > File
> >
>
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/315583004/diff/1/chrome/android/shell/java/sr...
> >
>
chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java:58:
> > if (mSuggestionsPopup == null) return;
> > On 2014/06/03 21:50:00, Sungmann Cho wrote:
> > > I think we need to check the visibility of |mSuggestionsPopup| here.
Because
> > > there is a case where |mSuggestionsPopup| is not null but it is not
visible.
> > For
> > > instance, if we touch the out side of |mSuggestionsPopup| then it will
> > disappear
> > > but it will remain not null. So if we change the orientation of the device
> > then
> > > the invisible |mSuggestionsPopup| will be visible unintentionally.
> > 
> > Done.
> 
> It works perfect for me! Thanks! :)

lgtm

[aurimas (slooooooooow), 2014-06-03 22:25:56]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-06-03 22:27:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/315583004/20001

[aurimas (slooooooooow), 2014-06-03 22:32:52]

The CQ bit was unchecked by aurimas@chromium.org

[aurimas (slooooooooow), 2014-06-03 22:34:59]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2014-06-03 22:36:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aurimas@chromium.org/315583004/30003

[commit-bot: I haz the power, 2014-06-04 02:39:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[commit-bot: I haz the power, 2014-06-04 09:37:40]

Change committed as 274753