Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 315583002: First step in reducing the size of PC descriptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments, added arm64 file. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_arm64.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm64.cc (revision 36988)
+++ runtime/vm/flow_graph_compiler_arm64.cc (working copy)
@@ -970,9 +970,8 @@
__ LoadObject(function_reg, function, new_pp);
// Patch point is after the eventually inlined function object.
- AddCurrentDescriptor(PcDescriptors::kEntryPatch,
- Isolate::kNoDeoptId,
- 0); // No token position.
+ entry_patch_pc_offset_ = assembler()->CodeSize();
+
intptr_t threshold = FLAG_optimization_counter_threshold;
__ LoadFieldFromOffset(
R7, function_reg, Function::usage_counter_offset(), new_pp);
@@ -999,9 +998,7 @@
// Set up pool pointer in new_pp.
__ LoadPoolPointer(new_pp);
- AddCurrentDescriptor(PcDescriptors::kEntryPatch,
- Isolate::kNoDeoptId,
- 0); // No token position.
+ entry_patch_pc_offset_ = assembler()->CodeSize();
}
__ Comment("Enter frame");
if (flow_graph().IsCompiledForOsr()) {
@@ -1102,17 +1099,16 @@
__ hlt(0);
GenerateDeferredCode();
+
// Emit function patching code. This will be swapped with the first 3
// instructions at entry point.
- AddCurrentDescriptor(PcDescriptors::kPatchCode,
- Isolate::kNoDeoptId,
- 0); // No token position.
+ patch_code_pc_offset_ = assembler()->CodeSize();
__ BranchPatchable(&StubCode::FixCallersTargetLabel());
- AddCurrentDescriptor(PcDescriptors::kLazyDeoptJump,
- Isolate::kNoDeoptId,
- 0); // No token position.
+ if (is_optimizing()) {
+ lazy_deopt_pc_offset_ = assembler()->CodeSize();
__ BranchPatchable(&StubCode::DeoptimizeLazyLabel());
+ }
}

Powered by Google App Engine
This is Rietveld 408576698