Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: runtime/vm/raw_object.h

Issue 315583002: First step in reducing the size of PC descriptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: addressed comments, added arm64 file. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_RAW_OBJECT_H_ 5 #ifndef VM_RAW_OBJECT_H_
6 #define VM_RAW_OBJECT_H_ 6 #define VM_RAW_OBJECT_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/token.h" 10 #include "vm/token.h"
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 } 833 }
834 834
835 // Compilation timestamp. 835 // Compilation timestamp.
836 int64_t compile_timestamp_; 836 int64_t compile_timestamp_;
837 intptr_t pointer_offsets_length_; 837 intptr_t pointer_offsets_length_;
838 // Alive: If true, the embedded object pointers will be visited during GC. 838 // Alive: If true, the embedded object pointers will be visited during GC.
839 // This field cannot be shorter because of alignment issues on x64 839 // This field cannot be shorter because of alignment issues on x64
840 // architectures. 840 // architectures.
841 intptr_t state_bits_; // state, is_optimized, is_alive. 841 intptr_t state_bits_; // state, is_optimized, is_alive.
842 842
843 // PC offsets for code patching.
844 intptr_t entry_patch_pc_offset_;
Ivan Posva 2014/06/05 22:28:04 Do these have to be intptr_t or would a sized poin
Florian Schneider 2014/06/06 08:54:27 I guess int32_t would be enough for the size of ge
845 intptr_t patch_code_pc_offset_;
846 intptr_t lazy_deopt_pc_offset_;
847
843 // Variable length data follows here. 848 // Variable length data follows here.
844 int32_t data_[0]; 849 int32_t data_[0];
845 850
846 friend class StackFrame; 851 friend class StackFrame;
847 friend class MarkingVisitor; 852 friend class MarkingVisitor;
848 friend class Function; 853 friend class Function;
849 }; 854 };
850 855
851 856
852 class RawInstructions : public RawObject { 857 class RawInstructions : public RawObject {
(...skipping 996 matching lines...) Expand 10 before | Expand all | Expand 10 after
1849 COMPILE_ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 14); 1854 COMPILE_ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 14);
1850 COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid == 1855 COMPILE_ASSERT(kExternalTypedDataInt8ArrayCid ==
1851 kTypedDataInt8ArrayViewCid + 15); 1856 kTypedDataInt8ArrayViewCid + 15);
1852 COMPILE_ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 14); 1857 COMPILE_ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 14);
1853 return (kNullCid - kTypedDataInt8ArrayCid); 1858 return (kNullCid - kTypedDataInt8ArrayCid);
1854 } 1859 }
1855 1860
1856 } // namespace dart 1861 } // namespace dart
1857 1862
1858 #endif // VM_RAW_OBJECT_H_ 1863 #endif // VM_RAW_OBJECT_H_
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698