chrome/browser/ui/omnibox/location_bar.cc - Issue 315573003: Remove PermissionsData::ForExtension() completely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/location_bar.cc

Issue 315573003: Remove PermissionsData::ForExtension() completely (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/location_bar.cc

diff --git a/chrome/browser/ui/omnibox/location_bar.cc b/chrome/browser/ui/omnibox/location_bar.cc

index f51dfce5688ab95713f486145746a6b30309daef..c41bb1089f956108eb2d62ea8550114c07c65775 100644

--- a/chrome/browser/ui/omnibox/location_bar.cc

+++ b/chrome/browser/ui/omnibox/location_bar.cc

@@ -33,7 +33,7 @@ bool LocationBar::IsBookmarkStarHiddenByExtension() const {

if (((settings_overrides &&

SettingsOverrides::RemovesBookmarkButton(*settings_overrides)) ||

(ui_overrides && UIOverrides::RemovesBookmarkButton(*ui_overrides))) &&

- (extensions::PermissionsData::ForExtension(*i)->HasAPIPermission(

+ ((*i)->permissions_data()->HasAPIPermission(

extensions::APIPermission::kBookmarkManagerPrivate) ||

extensions::FeatureSwitch::enable_override_bookmarks_ui()

->IsEnabled()))