chrome/browser/extensions/api/media_galleries/media_galleries_api.cc - Issue 315573003: Remove PermissionsData::ForExtension() completely

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

Issue 315573003: Remove PermissionsData::ForExtension() completely (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api.cc ('k') | chrome/browser/extensions/api/tab_capture/tab_capture_api.cc » ('j') | extensions/common/extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

diff --git a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

index 77edb3e3cc73f2c906cd6a2f3901a5c48096003e..21d205d23b6bc57b2141673f0c5115e993646153 100644

--- a/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

+++ b/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc

@@ -143,8 +143,7 @@ base::ListValue* ConstructFileSystemList(

MediaGalleriesPermission::CheckParam read_param(

MediaGalleriesPermission::kReadPermission);

- const PermissionsData* permissions_data =

- PermissionsData::ForExtension(extension);

+ const PermissionsData* permissions_data = extension->permissions_data();

bool has_read_permission = permissions_data->CheckAPIPermissionWithParam(

APIPermission::kMediaGalleries, &read_param);

MediaGalleriesPermission::CheckParam copy_to_param(

@@ -211,7 +210,7 @@ bool CheckScanPermission(const extensions::Extension* extension,

MediaGalleriesPermission::CheckParam scan_param(

MediaGalleriesPermission::kScanPermission);

bool has_scan_permission =

- PermissionsData::ForExtension(extension)->CheckAPIPermissionWithParam(

+ extension->permissions_data()->CheckAPIPermissionWithParam(

APIPermission::kMediaGalleries, &scan_param);

if (!has_scan_permission)

*error = kNoScanPermission;