Remove PermissionsData::ForExtension() completely

extensions/common/extension_messages.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/extension_messages.h"
 
 #include "content/public/common/common_param_traits.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/manifest.h"
 #include "extensions/common/manifest_handler.h"
@@ skipping 29 matching lines @@
       scriptable_hosts(extension->GetActivePermissions()->scriptable_hosts()),
       id(extension->id()),
       creation_flags(extension->creation_flags()) {
 }
 
 scoped_refptr<Extension> ExtensionMsg_Loaded_Params::ConvertToExtension(
     std::string* error) const {
   scoped_refptr<Extension> extension =
       Extension::Create(path, location, *manifest, creation_flags, error);
   if (extension.get()) {
-    extensions::PermissionsData::ForExtension(extension)
-        ->SetActivePermissions(new PermissionSet(
-            apis, manifest_permissions, explicit_hosts, scriptable_hosts));
+    extension->permissions_data()->SetActivePermissions(new PermissionSet(
+        apis, manifest_permissions, explicit_hosts, scriptable_hosts));
   }
   return extension;
 }
 
 namespace IPC {
 
 template <>
 struct ParamTraits<Manifest::Location> {
   typedef Manifest::Location param_type;
   static void Write(Message* m, const param_type& p) {
@@ skipping 177 matching lines @@
          ReadParam(m, iter, &p->explicit_hosts) &&
          ReadParam(m, iter, &p->scriptable_hosts);
 }
 
 void ParamTraits<ExtensionMsg_Loaded_Params>::Log(const param_type& p,
                                                   std::string* l) {
   l->append(p.id);
 }
 
 }  // namespace IPC