Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2025)

Unified Diff: Source/modules/device_orientation/DeviceMotionDispatcher.h

Issue 315573002: Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add stopUpdating in destructor of BatteryManager. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/device_orientation/DeviceMotionDispatcher.h
diff --git a/Source/modules/device_orientation/DeviceMotionDispatcher.h b/Source/modules/device_orientation/DeviceMotionDispatcher.h
index 0f21d733bc912a1efe208147c6d4f2d1efa017a5..227a5bb3742a06bb9805d04094d550e2a6d175dd 100644
--- a/Source/modules/device_orientation/DeviceMotionDispatcher.h
+++ b/Source/modules/device_orientation/DeviceMotionDispatcher.h
@@ -31,7 +31,7 @@
#ifndef DeviceMotionDispatcher_h
#define DeviceMotionDispatcher_h
-#include "core/frame/DeviceSensorEventDispatcher.h"
+#include "core/frame/DeviceEventDispatcherBase.h"
#include "platform/heap/Handle.h"
#include "public/platform/WebDeviceMotionListener.h"
#include "wtf/RefPtr.h"
@@ -45,9 +45,8 @@ namespace WebCore {
class DeviceMotionController;
class DeviceMotionData;
-// This class listens to device motion data and dispatches it to all
-// listening controllers.
-class DeviceMotionDispatcher FINAL : public DeviceSensorEventDispatcher, public blink::WebDeviceMotionListener {
+// This class listens to device motion data and notifies all registered controllers.
+class DeviceMotionDispatcher FINAL : public DeviceEventDispatcherBase, public blink::WebDeviceMotionListener {
public:
static DeviceMotionDispatcher& instance();
@@ -55,15 +54,14 @@ public:
// FIXME: make the return value const, see crbug.com/233174.
DeviceMotionData* latestDeviceMotionData();
- // This method is called every time new device motion data is available.
+ // Inherited from WebDeviceMotionListener.
virtual void didChangeDeviceMotion(const blink::WebDeviceMotionData&) OVERRIDE;
- void addDeviceMotionController(DeviceMotionController*);
- void removeDeviceMotionController(DeviceMotionController*);
private:
DeviceMotionDispatcher();
virtual ~DeviceMotionDispatcher();
+ // Inherited from DeviceEventDispatcherBase.
virtual void startListening() OVERRIDE;
virtual void stopListening() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698