Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets.

Source/core/frame/DeviceSingleWindowEventController.h

+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef DeviceSingleWindowEventController_h
+#define DeviceSingleWindowEventController_h
+
+#include "core/frame/DOMWindowLifecycleObserver.h"
+#include "core/frame/DeviceEventControllerBase.h"
+#include "platform/heap/Handle.h"
+
+namespace WebCore {
+
+class Document;
+class Event;
+
+class DeviceSingleWindowEventController : public DeviceEventControllerBase, public DOMWindowLifecycleObserver {
+

[Inactive, 2014/06/03 13:49:33]

nit: extra line

[timvolodine, 2014/06/03 18:45:54]

Done.

+public:
+    // Inherited from DeviceEventControllerBase.
+    virtual void didUpdateData() OVERRIDE;

[Inactive, 2014/06/03 13:49:33]

Why does this need to be public?

[timvolodine, 2014/06/03 18:45:54]

it's public in the base class and also called by the DeviceEventDispatcherBase.

+
+    // Inherited from DOMWindowLifecycleObserver.

[Inactive, 2014/06/03 13:49:33]

Why do these need to be public?

[timvolodine, 2014/06/03 18:45:54]

they are public in DOMWindowLifecycleObserver.

[Inactive, 2014/06/03 18:53:50]

Yes, but as long as these methods are not called on objects of type
DeviceSingleWindowEventController, there is no reason for us to override these
as public, right?

+    virtual void didAddEventListener(DOMWindow*, const AtomicString&) OVERRIDE;
+    virtual void didRemoveEventListener(DOMWindow*, const AtomicString&) OVERRIDE;
+    virtual void didRemoveAllEventListeners(DOMWindow*) OVERRIDE;
+
+protected:
+    explicit DeviceSingleWindowEventController(Document&);
+    virtual ~DeviceSingleWindowEventController();
+
+    void dispatchDeviceEvent(const PassRefPtrWillBeRawPtr<Event>);
+
+    virtual PassRefPtrWillBeRawPtr<Event> getLastEvent() = 0;

[Inactive, 2014/06/03 13:49:33]

We usually don't use "get" prefix for getters in Blink.
Could be const?

[timvolodine, 2014/06/03 18:45:54]

Done.

+    virtual const AtomicString& getEventTypeName() = 0;

[Inactive, 2014/06/03 13:49:33]

Ditto.

[timvolodine, 2014/06/03 18:45:54]

Done.

+    virtual bool isNullEvent(Event*) = 0;

[Inactive, 2014/06/03 13:49:33]

Could be const?

[timvolodine, 2014/06/03 18:45:54]

Done.

+
+private:
+    bool m_needsCheckingNullEvents;
+    Document& m_document;
+};
+
+} // namespace WebCore
+
+#endif // DeviceSingleWindowEventController_h