Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 315563005: Instrumented libraries: add a script to install build deps. (Closed)

Created:
6 years, 6 months ago by earthdok
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Instrumented libraries: add a script to install build deps. BUG=313751 R=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274881

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A third_party/instrumented_libraries/install-build-deps.sh View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
earthdok
ptal
6 years, 6 months ago (2014-06-03 17:38:02 UTC) #1
earthdok
FTR, https://code.google.com/p/chromium/issues/detail?id=313751#c12 suggests that we hand-pick dependencies and add them to build/install-build-deps.sh. I don't think ...
6 years, 6 months ago (2014-06-03 17:39:35 UTC) #2
Alexander Potapenko
LGTM in general. https://codereview.chromium.org/315563005/diff/1/third_party/instrumented_libraries/install-build-deps.sh File third_party/instrumented_libraries/install-build-deps.sh (right): https://codereview.chromium.org/315563005/diff/1/third_party/instrumented_libraries/install-build-deps.sh#newcode3 third_party/instrumented_libraries/install-build-deps.sh:3: # Copyright (c) 2012 The Chromium ...
6 years, 6 months ago (2014-06-04 12:32:22 UTC) #3
earthdok
ptal
6 years, 6 months ago (2014-06-04 13:36:25 UTC) #4
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-04 18:56:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/315563005/20001
6 years, 6 months ago (2014-06-04 18:58:52 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 19:00:51 UTC) #7
Message was sent while issue was closed.
Change committed as 274881

Powered by Google App Engine
This is Rietveld 408576698