Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 315563003: Instrumented libraries: fix & re-enable zlib1g build. (Closed)

Created:
6 years, 6 months ago by earthdok
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Instrumented libraries: fix & re-enable zlib1g build. The version script was being ignored in non-gcc (clang) builds. BUG=313751 TBR=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M third_party/instrumented_libraries/instrumented_libraries.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/instrumented_libraries/zlib1g.diff View 1 chunk +12 lines, -0 lines 0 comments Download
A + third_party/instrumented_libraries/zlib1g.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
earthdok
6 years, 6 months ago (2014-06-03 14:15:57 UTC) #1
earthdok
The CQ bit was checked by earthdok@chromium.org
6 years, 6 months ago (2014-06-03 14:37:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/315563003/1
6 years, 6 months ago (2014-06-03 14:37:49 UTC) #3
Alexander Potapenko
LGTM
6 years, 6 months ago (2014-06-03 14:38:46 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 14:48:14 UTC) #5
Message was sent while issue was closed.
Change committed as 274525

Powered by Google App Engine
This is Rietveld 408576698