Issue 315533002: %ObjectFreeze needs to exclude non-fast-path objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315533002: %ObjectFreeze needs to exclude non-fast-path objects. (Closed)

Created:
6 years, 6 months ago by mvstanton

Modified:
6 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

%ObjectFreeze needs to exclude non-fast-path objects. ClusterFuzz will call it with sloppy arguments and similar cases. BUG=380049 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21624

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/runtime.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-380049.js	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

lgtm. https://codereview.chromium.org/315533002/diff/1/test/mjsunit/regress/regress-380049.js File test/mjsunit/regress/regress-380049.js (right): https://codereview.chromium.org/315533002/diff/1/test/mjsunit/regress/regress-380049.js#newcode10 test/mjsunit/regress/regress-380049.js:10: %ObjectFreeze(f); how about assertThrows

6 years, 6 months ago (2014-06-03 07:20:28 UTC) #2

mvstanton

6 years, 6 months ago (2014-06-03 07:59:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21624 (presubmit successful).

Expand Messages | Collapse Messages