Source/core/editing/CompositeEditCommand.cpp - Issue 315513003: Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphConten

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 315513003: Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphConten (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index 69c7748e65f2f8ac8d192db9a258e9078de4fdb5..47bbcdadd14b3e778723b580147ffad882baf768 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -950,6 +950,9 @@ PassRefPtrWillBeRawPtr<Node> CompositeEditCommand::moveParagraphContentsToNewBlo

bool endWasBr = isHTMLBRElement(*visibleParagraphEnd.deepEquivalent().deprecatedNode());

+ visiblePos = VisiblePosition(pos, VP_DEFAULT_AFFINITY);

Yuta Kitamura 2014/06/04 08:22:46 It may be good to have some comments explaining wh

yosin_UTC9 2014/06/05 01:30:56 Done.

+ visibleParagraphStart = VisiblePosition(startOfParagraph(visiblePos));

+ visibleParagraphEnd = VisiblePosition(endOfParagraph(visiblePos));

moveParagraphs(visibleParagraphStart, visibleParagraphEnd, VisiblePosition(firstPositionInNode(newBlock.get())));

if (newBlock->lastChild() && isHTMLBRElement(*newBlock->lastChild()) && !endWasBr)

« no previous file with comments | « LayoutTests/editing/execCommand/apply-style-empty-paragraph-start-crash-expected.txt ('k') | no next file » | no next file with comments »