Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphConten

Make sure calling moveParagaph() with proper parameters in CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary()

This patch changes CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary()
to calculate start and end positions of paragraph to move before calling
moveParagraph(), because inserting paragraph element at |upstream| can change
start and end positions represented by |VisiblePosition|.

This patch is similar to http://crrev.com/311593003, for
InsertListCommand::listifyParagraph().

BUG=325222, 351291
TEST=LayoutTests/editing/execCommand/apply-style-empty-paragraph-start-crash.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175523

[yosin_UTC9, 2014-06-03 07:10:58]

Could you review this patch?
Thanks in advance.

Note: mac_blink_rel bot failure isn't related this patch.

[Yuta Kitamura, 2014-06-04 08:22:46]

LGTM with nit

https://codereview.chromium.org/315513003/diff/1/Source/core/editing/Composit...
File Source/core/editing/CompositeEditCommand.cpp (right):

https://codereview.chromium.org/315513003/diff/1/Source/core/editing/Composit...
Source/core/editing/CompositeEditCommand.cpp:953: visiblePos =
VisiblePosition(pos, VP_DEFAULT_AFFINITY);
It may be good to have some comments explaining why it's necessary
to reset these variables.

[yosin_UTC9, 2014-06-05 01:30:56]

Thanks for reviewing!
Committing...

https://codereview.chromium.org/315513003/diff/1/Source/core/editing/Composit...
File Source/core/editing/CompositeEditCommand.cpp (right):

https://codereview.chromium.org/315513003/diff/1/Source/core/editing/Composit...
Source/core/editing/CompositeEditCommand.cpp:953: visiblePos =
VisiblePosition(pos, VP_DEFAULT_AFFINITY);
On 2014/06/04 08:22:46, Yuta Kitamura wrote:
> It may be good to have some comments explaining why it's necessary
> to reset these variables.

Done.

[yosin_UTC9, 2014-06-05 01:30:59]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-06-05 01:31:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/315513003/10001

[commit-bot: I haz the power, 2014-06-05 03:05:20]

Change committed as 175523