Issue 3155020: Add GetHardwareKeyboardLayoutName method instead of kHardwareLayout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3155020: Add GetHardwareKeyboardLayoutName method instead of kHardwareLayout (Closed)

Created:
10 years, 4 months ago by Hitoshi Yoshida

Modified:
9 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-os-reviews_chromium.org, DaveMoore

Base URL:
http://src.chromium.org/git/cros.git

Visibility:
Public.

Description

Add GetHardwareKeyboardLayoutName() method in the class 'Keyboard' for constant string kHardwareLayout. BUG=chromuim-os:5579 TEST=See bug for details.

Patch Set 1 #

Patch Set 2 : add GethardwareKeyboardLayoutName() #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -1 line)			Patch
M	chromeos_cros_api.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos_keyboard.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos_keyboard.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	load.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

LGTM Could you update the CL description to include a BUG= and TEST= line? On ...

10 years, 4 months ago (2010-08-16 04:01:24 UTC) #2

I fixed BUG and TEST lines in the description.

Expand Messages | Collapse Messages