Source/core/editing/Editor.cpp - Issue 315493004: reset VisibleSelection at the Undo command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/Editor.cpp

Issue 315493004: reset VisibleSelection at the Undo command. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add the VisibleSelection::validateIfNeeded method Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/Editor.cpp

diff --git a/Source/core/editing/Editor.cpp b/Source/core/editing/Editor.cpp

index e2b1faa4d1c1eab468eb37be8e8b268ae69f51ec..f1044e816a0bd4b4274aaabdc61bc328b00aa359 100644

--- a/Source/core/editing/Editor.cpp

+++ b/Source/core/editing/Editor.cpp

@@ -718,6 +718,7 @@ void Editor::unappliedEditing(PassRefPtrWillBeRawPtr<EditCommandComposition> cmd

dispatchEditableContentChangedEvents(cmd->startingRootEditableElement(), cmd->endingRootEditableElement());

VisibleSelection newSelection(cmd->startingSelection());

+ newSelection.validatePositionsIfNeeded();

changeSelectionAfterCommand(newSelection, FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle);

m_lastEditCommand = nullptr;

« no previous file with comments | « Source/core/dom/Range.cpp ('k') | Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »