Stop having HTMLNameCollection override HTMLCollection::virtualItemAfter()

Stop having HTMLNameCollection override HTMLCollection::virtualItemAfter()

Stop having HTMLNameCollection override HTMLCollection::virtualItemAfter(). It
is not really needed as the same DOM tree traversal code. Instead, we simply
create 2 subclasses called DocumentNameCollection and WindowNameCollection that
define an elementMatches() method that is called from HTMLCollection, similarly
to other HTMLCollection subclasses.

This avoids having a virtual function call, brings support for efficient
backward traversal of these collections and leverages optimizations in
HTMLCollection.

This CL is inspired from WebKit r149652 from rniwa@webkit.org:
http://trac.webkit.org/changeset/149652

R=esprehn@chromium.org, adamk@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175476

[adamk, 2014-06-03 20:20:55]

lgtm

Seems fine to me

https://codereview.chromium.org/315473002/diff/20001/Source/core/html/Documen...
File Source/core/html/DocumentNameCollection.h (right):

https://codereview.chromium.org/315473002/diff/20001/Source/core/html/Documen...
Source/core/html/DocumentNameCollection.h:16: ASSERT_UNUSED(type, type ==
DocumentNamedItems);
Seems like we might want to add a new addCache() method to avoid passing type
around unnecessarily, now that so many types have dedicated classes that go with
them. But maybe further duplication in NodeRareData.h isn't worth it?

[Inactive, 2014-06-03 21:12:42]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-03 21:13:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/315473002/20001

[commit-bot: I haz the power, 2014-06-03 22:42:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6843)

[Inactive, 2014-06-04 12:23:33]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-06-04 12:24:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/315473002/20001

[commit-bot: I haz the power, 2014-06-04 12:59:49]

Change committed as 175476