Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 315403007: Remove GraphicsContextCG. (Closed)

Created:
6 years, 6 months ago by jbroman
Modified:
6 years, 6 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Remove GraphicsContextCG. We haven't supported Core Graphics in some time. Only one of these functions is implemented at all, and it is unused. BUG=381789 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175724

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -55 lines) Patch
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +1 line, -11 lines 0 comments Download
D Source/platform/graphics/cg/GraphicsContextCG.h View 1 chunk +0 lines, -41 lines 0 comments Download
M Source/platform/image-decoders/ImageDecoder.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jbroman
6 years, 6 months ago (2014-06-06 18:41:18 UTC) #1
f(malita)
lgtm
6 years, 6 months ago (2014-06-06 18:43:52 UTC) #2
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 6 months ago (2014-06-06 18:44:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/315403007/20001
6 years, 6 months ago (2014-06-06 18:45:17 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-06 19:39:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 19:39:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14910)
6 years, 6 months ago (2014-06-06 19:39:18 UTC) #7
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 6 months ago (2014-06-07 01:59:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/315403007/20001
6 years, 6 months ago (2014-06-07 02:00:09 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:30:46 UTC) #10
Message was sent while issue was closed.
Change committed as 175724

Powered by Google App Engine
This is Rietveld 408576698