Record SkPicture with correct LCD text setting.

ui/compositor/layer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/compositor/layer.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 636 matching lines @@
   if (layer_mask_)
     layer_mask_->OnDeviceScaleFactorChanged(device_scale_factor);
 }
 
 void Layer::RequestCopyOfOutput(scoped_ptr<cc::CopyOutputRequest> request) {
   cc_layer_->RequestCopyOfOutput(request.Pass());
 }
 
 void Layer::PaintContents(SkCanvas* sk_canvas,
                           const gfx::Rect& clip,
+                          bool can_paint_lcd_text,
                           gfx::RectF* opaque,
                           ContentLayerClient::GraphicsContextStatus gc_status) {
   TRACE_EVENT0("ui", "Layer::PaintContents");
   scoped_ptr<gfx::Canvas> canvas(gfx::Canvas::CreateCanvasWithoutScaling(
       sk_canvas, device_scale_factor_));
   if (delegate_)
     delegate_->OnPaintLayer(canvas.get());
 }
 
+bool Layer::PaintsLCDText() const {
+  return false;

[alokp, 2014/06/10 20:54:43]

ui::Layer::PaintsLCDText returns false. If it returns true and lcd text is not
allowed it is reasonable that the layer is invalidated.

[piman, 2014/06/10 23:48:31]

I'm pretty sure the UI paints LCD text today. Is it ok to return false here?

[alokp, 2014/06/10 23:59:41]

Irrespective of cc::Layer::can_paint_lcd_text? If it does take that into
account, we would need to plumb the new can_paint_lcd_text argument on
ui::Layer::PaintContents (see above).

[piman, 2014/06/11 00:02:27]

Yes. I'm pretty sure that when that was added to cc::Layer, it was not plumbed
into the UI. The UI may be making the (slightly incorrect) assumption that
things are opaque and will work.

[alokp, 2014/06/11 01:01:36]

Hmm. In that case I agree that it is better to keep
ContentLayerClient::DidChangeLayerCanUseLCDText. I will update the patch.

+}
+
 bool Layer::FillsBoundsCompletely() const { return fills_bounds_completely_; }
 
 bool Layer::PrepareTextureMailbox(
     cc::TextureMailbox* mailbox,
     scoped_ptr<cc::SingleReleaseCallback>* release_callback,
     bool use_shared_memory) {
   if (!mailbox_release_callback_)
     return false;
   *mailbox = mailbox_;
   *release_callback = mailbox_release_callback_.Pass();
@@ skipping 308 matching lines @@
       children_.end(),
       std::bind2nd(std::mem_fun(&Layer::RemoveAnimatorsInTreeFromCollection),
                    collection));
 }
 
 bool Layer::IsAnimating() const {
   return animator_ && animator_->is_animating();
 }
 
 }  // namespace ui