Record SkPicture with correct LCD text setting.

cc/layers/content_layer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/content_layer.h"
 
 #include "base/auto_reset.h"
 #include "base/metrics/histogram.h"
 #include "base/time/time.h"
 #include "cc/layers/content_layer_client.h"
 #include "cc/resources/bitmap_content_layer_updater.h"
 #include "cc/resources/bitmap_skpicture_content_layer_updater.h"
-#include "cc/resources/layer_painter.h"
+#include "cc/resources/content_layer_painter.h"
 #include "cc/trees/layer_tree_host.h"
 #include "third_party/skia/include/core/SkPictureRecorder.h"
 
 namespace cc {
 
-ContentLayerPainter::ContentLayerPainter(ContentLayerClient* client)
-    : client_(client) {}
-
-scoped_ptr<ContentLayerPainter> ContentLayerPainter::Create(
-    ContentLayerClient* client) {
-  return make_scoped_ptr(new ContentLayerPainter(client));
-}
-
-void ContentLayerPainter::Paint(SkCanvas* canvas,
-                                const gfx::Rect& content_rect,
-                                gfx::RectF* opaque) {
-  client_->PaintContents(canvas,
-                         content_rect,
-                         opaque,
-                         ContentLayerClient::GRAPHICS_CONTEXT_ENABLED);
-}
-
 scoped_refptr<ContentLayer> ContentLayer::Create(ContentLayerClient* client) {
   return make_scoped_refptr(new ContentLayer(client));
 }
 
 ContentLayer::ContentLayer(ContentLayerClient* client)
-    : TiledLayer(),
-      client_(client),
-      can_use_lcd_text_last_frame_(can_use_lcd_text()) {
+    : client_(client), use_lcd_text_(true) {
 }
 
 ContentLayer::~ContentLayer() {}
 
 bool ContentLayer::DrawsContent() const {
   return TiledLayer::DrawsContent() && client_;
 }
 
 void ContentLayer::SetLayerTreeHost(LayerTreeHost* host) {
   TiledLayer::SetLayerTreeHost(host);
@@ skipping 17 matching lines @@
   TiledLayer::SetTexturePriorities(priority_calc);
 }
 
 bool ContentLayer::Update(ResourceUpdateQueue* queue,
                           const OcclusionTracker<Layer>* occlusion) {
   {
     base::AutoReset<bool> ignore_set_needs_commit(&ignore_set_needs_commit_,
                                                   true);
 
     CreateUpdaterIfNeeded();
-    UpdateCanUseLCDText();
+    UpdateUseLCDText();
   }
 
   bool updated = TiledLayer::Update(queue, occlusion);
   return updated;
 }
 
 bool ContentLayer::NeedMoreUpdates() {
   return NeedsIdlePaint();
 }
 
 LayerUpdater* ContentLayer::Updater() const {
   return updater_.get();
 }
 
 void ContentLayer::CreateUpdaterIfNeeded() {
   if (updater_.get())
     return;
-  scoped_ptr<LayerPainter> painter =
-      ContentLayerPainter::Create(client_).PassAs<LayerPainter>();
+  scoped_ptr<ContentLayerPainter> painter =
+      ContentLayerPainter::Create(client_);
   if (layer_tree_host()->settings().per_tile_painting_enabled) {
     updater_ = BitmapSkPictureContentLayerUpdater::Create(
         painter.Pass(),
         rendering_stats_instrumentation(),
         id());
   } else {
     updater_ = BitmapContentLayerUpdater::Create(
         painter.Pass(),
         rendering_stats_instrumentation(),
         id());
   }
   updater_->SetOpaque(contents_opaque());
   if (client_)
     updater_->SetFillsBoundsCompletely(client_->FillsBoundsCompletely());
+  updater_->set_can_use_lcd_text(use_lcd_text_);
 
   SetTextureFormat(
       layer_tree_host()->GetRendererCapabilities().best_texture_format);
 }
 
 void ContentLayer::SetContentsOpaque(bool opaque) {
   Layer::SetContentsOpaque(opaque);
   if (updater_.get())
     updater_->SetOpaque(opaque);
 }
 
-void ContentLayer::UpdateCanUseLCDText() {
-  if (can_use_lcd_text_last_frame_ == can_use_lcd_text())
+void ContentLayer::UpdateUseLCDText() {
+  if (use_lcd_text_ == can_use_lcd_text())
     return;
 
-  can_use_lcd_text_last_frame_ = can_use_lcd_text();
-  if (client_)
-    client_->DidChangeLayerCanUseLCDText();
+  // LCD text starts out enabled and can only be disabled.
+  if (!use_lcd_text_)
+    return;
+
+  use_lcd_text_ = can_use_lcd_text();
+  updater_->set_can_use_lcd_text(use_lcd_text_);
+  if (client_->PaintsLCDText())
+    SetNeedsDisplay();
 }
 
 bool ContentLayer::SupportsLCDText() const {
   return true;
 }
 
 skia::RefPtr<SkPicture> ContentLayer::GetPicture() const {
   if (!DrawsContent())
     return skia::RefPtr<SkPicture>();
 
   int width = bounds().width();
   int height = bounds().height();
   gfx::RectF opaque;
 
   SkPictureRecorder recorder;
   SkCanvas* canvas = recorder.beginRecording(width, height, NULL, 0);
   client_->PaintContents(canvas,
                          gfx::Rect(width, height),
+                         use_lcd_text_,
                          &opaque,
                          ContentLayerClient::GRAPHICS_CONTEXT_ENABLED);
   skia::RefPtr<SkPicture> picture = skia::AdoptRef(recorder.endRecording());
   return picture;
 }
 
 void ContentLayer::OnOutputSurfaceCreated() {
   SetTextureFormat(
       layer_tree_host()->GetRendererCapabilities().best_texture_format);
   TiledLayer::OnOutputSurfaceCreated();
 }
 
 }  // namespace cc