Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 315383003: Linux sandbox: restrict prctl in the baseline. (Closed)

Created:
6 years, 6 months ago by jln (very slow on Chromium)
Modified:
6 years, 6 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org, Mark Seaborn
Visibility:
Public.

Description

Linux sandbox: restrict prctl in the baseline. Restrict prctl(2) in the baseline policy. We temporarily allow in the GPU and PPAPI policies, so the net effect of this CL is only to restrict prctl for NaCl processes. BUG=270914 R=mdempsky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275284

Patch Set 1 #

Patch Set 2 : Android header workaround. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/sandbox_linux/bpf_ppapi_policy_linux.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 3 chunks +4 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy_unittest.cc View 1 2 chunks +21 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Matthew: PTAL! Mark: FYI, this will restrict prctl in NaCl to PR_SET_NAME, PR_SET_DUMPABLE, PR_GET_DUMPABLE, crash ...
6 years, 6 months ago (2014-06-05 22:53:45 UTC) #1
mdempsky
lgtm
6 years, 6 months ago (2014-06-05 23:00:43 UTC) #2
jln (very slow on Chromium)
6 years, 6 months ago (2014-06-06 00:44:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r275284 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698