Cleaning WebDOMActivityLogger interface.

Cleaning WebDOMActivityLogger interface. Deprecating old methods. Fixing assignment of ActivityLogger to V8PerContextData.

BUG=366916
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175678

[pmarch, 2014-06-05 22:51:14]

Hi Jochen

Could you please check this small CL.

Thanks

[haraken, 2014-06-05 23:32:03]

LGTM

[jochen (gone - plz use gerrit), 2014-06-06 06:55:33]

lgtm

https://codereview.chromium.org/315373002/diff/1/Source/bindings/v8/V8DOMActi...
File Source/bindings/v8/V8DOMActivityLogger.cpp (left):

https://codereview.chromium.org/315373002/diff/1/Source/bindings/v8/V8DOMActi...
Source/bindings/v8/V8DOMActivityLogger.cpp:41:
domActivityLoggersForIsolatedWorld().set(worldId, logger);
nit. no { } for single line bodies

[pmarch, 2014-06-06 14:10:55]

On 2014/06/06 06:55:33, jochen traveling until Jun 23 wrote:
> lgtm
> 
>
https://codereview.chromium.org/315373002/diff/1/Source/bindings/v8/V8DOMActi...
> File Source/bindings/v8/V8DOMActivityLogger.cpp (left):
> 
>
https://codereview.chromium.org/315373002/diff/1/Source/bindings/v8/V8DOMActi...
> Source/bindings/v8/V8DOMActivityLogger.cpp:41:
> domActivityLoggersForIsolatedWorld().set(worldId, logger);
> nit. no { } for single line bodies

done

[pmarch, 2014-06-06 14:16:04]

Haraken

Can you have another look. I've added updating activity logger on document
change. This is required because we rely on page URL to identify extension ID
and find activity logger for a main world. When extension background page issues
window.open(<url to the extension's option page>) the activity logger is
assigned when page url is blank (the page has not been loaded yet) and when the
page is loaded the url is updated. When the page is loaded, I also need to
update the activity logger since there was no logger assigned when the page URL
was blank.

[haraken, 2014-06-06 14:26:18]

LGTM

[pmarch, 2014-06-06 17:14:21]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:14:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/315373002/20001

[commit-bot: I haz the power, 2014-06-06 17:17:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7178)

[commit-bot: I haz the power, 2014-06-06 17:20:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:20:02]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7179)

[pmarch, 2014-06-06 17:34:09]

The CQ bit was checked by pmarch@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:35:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pmarch@chromium.org/315373002/20001

[commit-bot: I haz the power, 2014-06-06 17:38:31]

Change committed as 175678