Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 315343002: Fixed bad arguments to gsutil (Closed)

Created:
6 years, 6 months ago by hinoka
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Fixed bad arguments to gsutil boto is required. BUG=261741 TBR=iannucci Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=275244

Patch Set 1 #

Patch Set 2 : boto_path, not boto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M git_cache.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Ryan Tseng
I derped.
6 years, 6 months ago (2014-06-05 21:10:01 UTC) #1
David Yen
lgtm
6 years, 6 months ago (2014-06-05 21:10:50 UTC) #2
Ryan Tseng
PS2: Its boto_path, not boto
6 years, 6 months ago (2014-06-05 21:12:10 UTC) #3
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 6 months ago (2014-06-05 21:12:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/315343002/20001
6 years, 6 months ago (2014-06-05 21:12:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 21:12:51 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-05 21:12:52 UTC) #7
Ryan Tseng
TBR iannucci since this blocks new bot_update rolls (and apparently some people use this irl) ...
6 years, 6 months ago (2014-06-05 21:16:50 UTC) #8
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 6 months ago (2014-06-05 21:16:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@chromium.org/315343002/20001
6 years, 6 months ago (2014-06-05 21:17:51 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 21:19:40 UTC) #11
Message was sent while issue was closed.
Change committed as 275244

Powered by Google App Engine
This is Rietveld 408576698