Issue 315333002: Oilpan: tidy up reference to the Document's "CSS target".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315333002: Oilpan: tidy up reference to the Document's "CSS target". (Closed)

Created:
6 years, 6 months ago by sof

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, tkent, haraken

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: tidy up reference to the Document's "CSS target". Keep a traced Member reference to the Element that's recorded as the Document's CSS target. When that Element is removed from the tree, the Member will be explicitly cleared. R= BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175609

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -7 lines)			Patch
M	Source/core/dom/ContainerNode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View	3 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look. I don't think a weak reference is needed here.

6 years, 6 months ago (2014-06-05 21:53:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/315333002/1

6 years, 6 months ago (2014-06-05 23:28:21 UTC) #3

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages