build/common.gypi - Issue 315323002: Disable Warning 4702 for the PGO builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 315323002: Disable Warning 4702 for the PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the TODO. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 5a2753f08af3172e7c9d25e2efb04e6479d74aad..dd5a7db8a3df8cbdad9716d58949438fdcf462a4 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -4967,6 +4967,11 @@

['optimize=="max"', {

+ # Disable Warning 4702 ("Unreachable code") for the WPO/PGO

+ # builds, see crbug.com/380175.

Peter Kasting 2014/06/05 23:38:10 Nit: Try to avoid referring to bugs in comments, i

+ 'msvs_disabled_warnings': [

+ 4702

+ ],

'msvs_settings': {

'VCCLCompilerTool': {

# 2, optimizeMaxSpeed, Maximize Speed (/O2)

« no previous file with comments | « base/logging.cc ('k') | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »