Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2434)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/common.gypi

Issue 315323002: Disable Warning 4702 for the PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/logging.cc ('k') | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5a2753f08af3172e7c9d25e2efb04e6479d74aad..1f3a24ab2c89529324ddd9cbe3bab72f65e1b69d 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -4967,6 +4967,13 @@
},
],
['optimize=="max"', {
+ # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
+ # builds, see crbug.com/380175.
+ # TODO(sebmarchand): Re-enable this once it doesn't trigger
scottmg 2014/06/05 21:10:08 I think you can remove this TODO.
Sébastien Marchand 2014/06/05 21:18:39 Done.
+ # anymore when doing a PGO build.
+ 'msvs_disabled_warnings': [
+ 4702
+ ],
'msvs_settings': {
'VCCLCompilerTool': {
# 2, optimizeMaxSpeed, Maximize Speed (/O2)
« no previous file with comments | « base/logging.cc ('k') | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698