Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: build/common.gypi

Issue 315323002: Disable Warning 4702 for the PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Brett's comment. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/logging.cc ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 4949 matching lines...) Expand 10 before | Expand all | Expand 10 after
4960 'VCCLCompilerTool': { 4960 'VCCLCompilerTool': {
4961 # 2, optimizeMaxSpeed, Maximize Speed (/O2) 4961 # 2, optimizeMaxSpeed, Maximize Speed (/O2)
4962 'Optimization': '2', 4962 'Optimization': '2',
4963 # 1, favorSpeed - Favor fast code (/Ot) 4963 # 1, favorSpeed - Favor fast code (/Ot)
4964 'FavorSizeOrSpeed': '1', 4964 'FavorSizeOrSpeed': '1',
4965 }, 4965 },
4966 }, 4966 },
4967 }, 4967 },
4968 ], 4968 ],
4969 ['optimize=="max"', { 4969 ['optimize=="max"', {
4970 # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
4971 # builds. Probably anything that this would catch that
4972 # wouldn't be caught in a normal build isn't going to
4973 # actually be a bug, so the incremental value of C4702 for
4974 # PGO builds is likely very small.
4975 'msvs_disabled_warnings': [
4976 4702
4977 ],
4970 'msvs_settings': { 4978 'msvs_settings': {
4971 'VCCLCompilerTool': { 4979 'VCCLCompilerTool': {
4972 # 2, optimizeMaxSpeed, Maximize Speed (/O2) 4980 # 2, optimizeMaxSpeed, Maximize Speed (/O2)
4973 'Optimization': '2', 4981 'Optimization': '2',
4974 # 1, favorSpeed - Favor fast code (/Ot) 4982 # 1, favorSpeed - Favor fast code (/Ot)
4975 'FavorSizeOrSpeed': '1', 4983 'FavorSizeOrSpeed': '1',
4976 # This implies link time code generation. 4984 # This implies link time code generation.
4977 'WholeProgramOptimization': 'true', 4985 'WholeProgramOptimization': 'true',
4978 }, 4986 },
4979 }, 4987 },
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
5429 # settings in target dicts. SYMROOT is a special case, because many other 5437 # settings in target dicts. SYMROOT is a special case, because many other
5430 # Xcode variables depend on it, including variables such as 5438 # Xcode variables depend on it, including variables such as
5431 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5439 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5432 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5440 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5433 # files to appear (when present) in the UI as actual files and not red 5441 # files to appear (when present) in the UI as actual files and not red
5434 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5442 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5435 # and therefore SYMROOT, needs to be set at the project level. 5443 # and therefore SYMROOT, needs to be set at the project level.
5436 'SYMROOT': '<(DEPTH)/xcodebuild', 5444 'SYMROOT': '<(DEPTH)/xcodebuild',
5437 }, 5445 },
5438 } 5446 }
OLDNEW
« no previous file with comments | « base/logging.cc ('k') | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698