Issue 315313002: Roll pdfium, add GN build for pdf and pdfium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315313002: Roll pdfium, add GN build for pdf and pdfium. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Roll pdfium, add GN build for pdf and pdfium. Pdfium changes: d68f9a3 Add GN build file for pdfium, rename GYP target. f0a5576 fix two uninitialized reads https://code.google.com/p/pdfium/issues/detail?id=9 https://code.google.com/p/pdfium/issues/detail?id=10 bb2b1e7 Use unsigned type for iteration to avoid int overflow. 62a7fd6 Wrong variable assignment in Pdfium. In the GN build this separates out the no-exceptions flag since pdfium must be compiled with exceptions enabled. Updates pdfium naming in GYP from fpdfsdk. Removes src/pdf from .gitignore now that it is checked in. BUG= R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275269

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -8 lines)			Patch
M	.gitignore	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	BUILD.gn	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	build/config/BUILDCONFIG.gn	View	2 chunks	+10 lines, -4 lines	0 comments	Download
M	build/config/compiler/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/config/gcc/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	pdf/BUILD.gn	View	1 chunk	+108 lines, -0 lines	0 comments	Download
M	pdf/pdf.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

brettw

6 years, 6 months ago (2014-06-05 23:19:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r275269 (presubmit successful).