Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: chrome/browser/browser_focus_uitest.cc

Issue 3153039: Fix tabbing into web area not focusing first element.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/cocoa/base_view.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/format_macros.h" 8 #include "base/format_macros.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 29 matching lines...) Expand all
40 #if defined(TOOLKIT_USES_GTK) 40 #if defined(TOOLKIT_USES_GTK)
41 #include "chrome/browser/gtk/view_id_util.h" 41 #include "chrome/browser/gtk/view_id_util.h"
42 #endif 42 #endif
43 43
44 #if defined(OS_LINUX) 44 #if defined(OS_LINUX)
45 #define MAYBE_FocusTraversal FocusTraversal 45 #define MAYBE_FocusTraversal FocusTraversal
46 #define MAYBE_FocusTraversalOnInterstitial FocusTraversalOnInterstitial 46 #define MAYBE_FocusTraversalOnInterstitial FocusTraversalOnInterstitial
47 // TODO(jcampan): http://crbug.com/23683 47 // TODO(jcampan): http://crbug.com/23683
48 #define MAYBE_TabsRememberFocusFindInPage FAILS_TabsRememberFocusFindInPage 48 #define MAYBE_TabsRememberFocusFindInPage FAILS_TabsRememberFocusFindInPage
49 #elif defined(OS_MACOSX) 49 #elif defined(OS_MACOSX)
50 // TODO(suzhe): http://crbug.com/49738 (following two tests) 50 // TODO(suzhe): http://crbug.com/60973 (following two tests)
51 #define MAYBE_FocusTraversal DISABLED_FocusTraversal 51 #define MAYBE_FocusTraversal DISABLED_FocusTraversal
52 #define MAYBE_FocusTraversalOnInterstitial DISABLED_FocusTraversalOnInterstitial 52 #define MAYBE_FocusTraversalOnInterstitial DISABLED_FocusTraversalOnInterstitial
53 // TODO(suzhe): http://crbug.com/49737 53 // TODO(suzhe): http://crbug.com/49737
54 #define MAYBE_TabsRememberFocusFindInPage FAILS_TabsRememberFocusFindInPage 54 #define MAYBE_TabsRememberFocusFindInPage FAILS_TabsRememberFocusFindInPage
55 #elif defined(OS_WIN) 55 #elif defined(OS_WIN)
56 #define MAYBE_FocusTraversal FocusTraversal 56 #define MAYBE_FocusTraversal FocusTraversal
57 #define MAYBE_FocusTraversalOnInterstitial FocusTraversalOnInterstitial 57 #define MAYBE_FocusTraversalOnInterstitial FocusTraversalOnInterstitial
58 #define MAYBE_TabsRememberFocusFindInPage TabsRememberFocusFindInPage 58 #define MAYBE_TabsRememberFocusFindInPage TabsRememberFocusFindInPage
59 #endif 59 #endif
60 60
(...skipping 716 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 ui_test_utils::CrashTab(browser()->GetSelectedTabContents()); 777 ui_test_utils::CrashTab(browser()->GetSelectedTabContents());
778 browser()->Reload(CURRENT_TAB); 778 browser()->Reload(CURRENT_TAB);
779 ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser())); 779 ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
780 780
781 // Focus should now be on the tab contents. 781 // Focus should now be on the tab contents.
782 browser()->ShowDownloadsTab(); 782 browser()->ShowDownloadsTab();
783 ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW)); 783 ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER_FOCUS_VIEW));
784 } 784 }
785 785
786 } // namespace 786 } // namespace
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/cocoa/base_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698