Issue 3153039: Fix tabbing into web area not focusing first element....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3153039: Fix tabbing into web area not focusing first element.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Avi

Modified:
4 years ago

Reviewers:
rohitrao (OOO until 6-22)

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org, ben+cc_chromium.org, John Grabowski, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix tabbing into web area not focusing first element. BUG=49738 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64465

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
M	chrome/browser/browser_focus_uitest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/base_view.h	View	2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/base_view.mm	View	2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View	2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_mac.mm	View	1 2	4 chunks	+25 lines, -0 lines	0 comments	Download

Trybot results:

Total messages: 3 (0 generated)

Avi

Punting on fixing the tests, which fail for a totally different reason...

4 years, 7 months ago (2010-10-27 20:24:25 UTC) #1

rohitrao (OOO until 6-22)

On 2010/10/27 20:24:25, Avi wrote: > Punting on fixing the tests, which fail for a ...

4 years, 7 months ago (2010-10-29 16:55:02 UTC) #2

Avi

4 years, 7 months ago (2010-10-29 16:56:44 UTC) #3

On 2010/10/29 16:55:02, rohitrao wrote:
> I dislike the notification, but I can't think of anything better right now.

Exactly my sentiments too. :(