Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: Source/core/rendering/RenderView.cpp

Issue 315293003: Add tracing for RenderView::hitTest and FrameView::invalidateTree. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Implement. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 { 75 {
76 } 76 }
77 77
78 bool RenderView::hitTest(const HitTestRequest& request, HitTestResult& result) 78 bool RenderView::hitTest(const HitTestRequest& request, HitTestResult& result)
79 { 79 {
80 return hitTest(request, result.hitTestLocation(), result); 80 return hitTest(request, result.hitTestLocation(), result);
81 } 81 }
82 82
83 bool RenderView::hitTest(const HitTestRequest& request, const HitTestLocation& l ocation, HitTestResult& result) 83 bool RenderView::hitTest(const HitTestRequest& request, const HitTestLocation& l ocation, HitTestResult& result)
84 { 84 {
85 TRACE_EVENT0("blink", "RenderView::hitTest");
86
85 // We have to recursively update layout/style here because otherwise, when t he hit test recurses 87 // We have to recursively update layout/style here because otherwise, when t he hit test recurses
86 // into a child document, it could trigger a layout on the parent document, which can destroy RenderLayers 88 // into a child document, it could trigger a layout on the parent document, which can destroy RenderLayers
87 // that are higher up in the call stack, leading to crashes. 89 // that are higher up in the call stack, leading to crashes.
88 // Note that Document::updateLayout calls its parent's updateLayout. 90 // Note that Document::updateLayout calls its parent's updateLayout.
89 // FIXME: It should be the caller's responsibility to ensure an up-to-date l ayout. 91 // FIXME: It should be the caller's responsibility to ensure an up-to-date l ayout.
90 frameView()->updateLayoutAndStyleIfNeededRecursive(); 92 frameView()->updateLayoutAndStyleIfNeededRecursive();
91 return layer()->hitTest(request, location, result); 93 return layer()->hitTest(request, location, result);
92 } 94 }
93 95
94 void RenderView::computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit, Logi calExtentComputedValues& computedValues) const 96 void RenderView::computeLogicalHeight(LayoutUnit logicalHeight, LayoutUnit, Logi calExtentComputedValues& computedValues) const
(...skipping 921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1016 return viewWidth(IncludeScrollbars) / scale; 1018 return viewWidth(IncludeScrollbars) / scale;
1017 } 1019 }
1018 1020
1019 double RenderView::layoutViewportHeight() const 1021 double RenderView::layoutViewportHeight() const
1020 { 1022 {
1021 float scale = m_frameView ? m_frameView->frame().pageZoomFactor() : 1; 1023 float scale = m_frameView ? m_frameView->frame().pageZoomFactor() : 1;
1022 return viewHeight(IncludeScrollbars) / scale; 1024 return viewHeight(IncludeScrollbars) / scale;
1023 } 1025 }
1024 1026
1025 } // namespace WebCore 1027 } // namespace WebCore
OLDNEW
« Source/core/frame/FrameView.cpp ('K') | « Source/core/frame/FrameView.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698