Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> | 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> |
| 3 * 1999 Lars Knoll <knoll@kde.org> | 3 * 1999 Lars Knoll <knoll@kde.org> |
| 4 * 1999 Antti Koivisto <koivisto@kde.org> | 4 * 1999 Antti Koivisto <koivisto@kde.org> |
| 5 * 2000 Dirk Mueller <mueller@kde.org> | 5 * 2000 Dirk Mueller <mueller@kde.org> |
| 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. | 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. |
| 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) | 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) |
| 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) | 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) |
| 9 * Copyright (C) 2009 Google Inc. All rights reserved. | 9 * Copyright (C) 2009 Google Inc. All rights reserved. |
| 10 * | 10 * |
| (...skipping 1018 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1029 if (frame().page()) | 1029 if (frame().page()) |
| 1030 frame().page()->chrome().client().layoutUpdated(m_frame.get()); | 1030 frame().page()->chrome().client().layoutUpdated(m_frame.get()); |
| 1031 } | 1031 } |
| 1032 | 1032 |
| 1033 // The plan is to move to compositor-queried paint invalidation, in which case t his | 1033 // The plan is to move to compositor-queried paint invalidation, in which case t his |
| 1034 // method would setNeedsRedraw on the GraphicsLayers with invalidations and | 1034 // method would setNeedsRedraw on the GraphicsLayers with invalidations and |
| 1035 // let the compositor pick which to actually draw. | 1035 // let the compositor pick which to actually draw. |
| 1036 // See http://crbug.com/306706 | 1036 // See http://crbug.com/306706 |
| 1037 void FrameView::invalidateTree(RenderObject* root) | 1037 void FrameView::invalidateTree(RenderObject* root) |
| 1038 { | 1038 { |
| 1039 TRACE_EVENT0("blink", "FrameView::invalidateTree"); | |
|
dsinclair
2014/06/06 01:59:03
This already exists on line 1047.
chrishtr
2014/06/06 02:08:03
Done.
ojan
2014/06/06 03:22:38
Why is the one on line 1047 disabled by default?
dsinclair
2014/06/06 03:29:27
The TRACE_STR_COPY has a cost which I didn't want
ojan
2014/06/06 05:53:11
Can we put in a trace (instead or in addition the
| |
| 1040 | |
| 1039 ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled()); | 1041 ASSERT(RuntimeEnabledFeatures::repaintAfterLayoutEnabled()); |
| 1040 ASSERT(!root->needsLayout()); | 1042 ASSERT(!root->needsLayout()); |
| 1041 // We should only invalidate paints for the outer most layout. This works as | 1043 // We should only invalidate paints for the outer most layout. This works as |
| 1042 // we continue to track paint invalidation rects until this function is call ed. | 1044 // we continue to track paint invalidation rects until this function is call ed. |
| 1043 ASSERT(!m_nestedLayoutCount); | 1045 ASSERT(!m_nestedLayoutCount); |
| 1044 | 1046 |
| 1045 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "FrameView::in validateTree", | 1047 TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.invalidation"), "FrameView::in validateTree", |
| 1046 "root", TRACE_STR_COPY(root->debugName().ascii().data())); | 1048 "root", TRACE_STR_COPY(root->debugName().ascii().data())); |
| 1047 | 1049 |
| 1048 // FIXME: really, we're in the paint invalidation phase here, and the compos iting queries are legal. | 1050 // FIXME: really, we're in the paint invalidation phase here, and the compos iting queries are legal. |
| (...skipping 2224 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3273 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) | 3275 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation o rientation) |
| 3274 { | 3276 { |
| 3275 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); | 3277 ScrollableArea::willRemoveScrollbar(scrollbar, orientation); |
| 3276 if (AXObjectCache* cache = axObjectCache()) { | 3278 if (AXObjectCache* cache = axObjectCache()) { |
| 3277 cache->remove(scrollbar); | 3279 cache->remove(scrollbar); |
| 3278 cache->handleScrollbarUpdate(this); | 3280 cache->handleScrollbarUpdate(this); |
| 3279 } | 3281 } |
| 3280 } | 3282 } |
| 3281 | 3283 |
| 3282 } // namespace WebCore | 3284 } // namespace WebCore |
| OLD | NEW |