Issue 315253002: DevTools: [JSDoc] Fix injected scripts JSDoc and related code

Issue 315253002: DevTools: [JSDoc] Fix injected scripts JSDoc and related code (Closed)

Created:
6 years, 6 months ago by apavlov

Modified:
6 years, 6 months ago

Reviewers:
aandrey

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [JSDoc] Fix injected scripts JSDoc and related code R=aandrey NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175656

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nullabilities in the injected scripts code #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -272 lines)			Patch
	M	Source/core/inspector/InjectedScriptCanvasModuleSource.js	View	1	145 chunks	+221 lines, -223 lines	0 comments	Download
	M	Source/core/inspector/InjectedScriptSource.js	View	1	33 chunks	+73 lines, -49 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

aandrey

lgtm https://codereview.chromium.org/315253002/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/315253002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode108 Source/core/inspector/InjectedScriptSource.js:108: * @param {Object} thisObject why the check for ...

6 years, 6 months ago (2014-06-05 19:08:25 UTC) #2

apavlov

https://codereview.chromium.org/315253002/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/315253002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode108 Source/core/inspector/InjectedScriptSource.js:108: * @param {Object} thisObject On 2014/06/05 19:08:24, aandrey wrote: ...

6 years, 6 months ago (2014-06-05 19:26:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/315253002/1

6 years, 6 months ago (2014-06-06 09:00:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/315253002/20001

6 years, 6 months ago (2014-06-06 10:59:34 UTC) #8

Message was sent while issue was closed.

Change committed as 175656

Expand Messages | Collapse Messages