Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 315233002: X87: Preliminary support for block contexts in hydrogen. (Closed)

Created:
6 years, 6 months ago by chunyang.dai
Modified:
6 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev, danno
Visibility:
Public.

Description

X87: Preliminary support for block contexts in hydrogen. Port r21684. Origin message: Preliminary support for block contexts in hydrogen. Patch from Steven Keuchel <keuchel@chromium.org>; BUG=v8:2198 LOG=N TEST=mjsunit/harmony/block-let-crankshaft.js

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.h View 3 chunks +31 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
hi, Ulan. please help to review the patch for x87 which is ported from r21684. ...
6 years, 6 months ago (2014-06-06 07:06:47 UTC) #1
ulan
lgtm
6 years, 6 months ago (2014-06-10 07:42:44 UTC) #2
Weiliang
6 years, 6 months ago (2014-06-10 08:12:35 UTC) #3
Committed patchset #1 as r21730

Powered by Google App Engine
This is Rietveld 408576698