Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 315223005: Fix adb_gdb --su-prefix (Closed)

Created:
6 years, 6 months ago by Zeeshan Qureshi
Modified:
6 years, 6 months ago
Reviewers:
bulach, digit1
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix adb_gdb --su-prefix |adb_gdb --su-prefix=su| wasn't working for me, so updating doc and script. BUG=337423 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/adb_gdb View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Zeeshan Qureshi
6 years, 6 months ago (2014-06-06 00:50:46 UTC) #1
bulach
lgtm, thanks!
6 years, 6 months ago (2014-06-06 08:45:52 UTC) #2
bulach
lgtm (I took the liberty to edit the message and BUG=337423)
6 years, 6 months ago (2014-06-06 11:07:31 UTC) #3
Zeeshan Qureshi
The CQ bit was checked by zeeshanq@chromium.org
6 years, 6 months ago (2014-06-06 17:05:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zeeshanq@chromium.org/315223005/1
6 years, 6 months ago (2014-06-06 17:07:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 20:17:56 UTC) #6
Message was sent while issue was closed.
Change committed as 275508

Powered by Google App Engine
This is Rietveld 408576698