Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 315223004: Moves view_manager files to view_manager directory (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Moves view_manager files to view_manager directory The WindowTreeHost and ContextFactory implementations are specific to the view manager and should be moved there. No one else should be using these directly. I'm also nuking launcher as it was temporary and the only other place that was using this code. BUG=365012 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275453

Patch Set 1 #

Patch Set 2 : tweak gyp #

Patch Set 3 : and nuke sampleviewmanagerapp #

Patch Set 4 : merge to trunk #

Patch Set 5 : rm sample_view_manager.app again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -910 lines) Patch
D mojo/aura/context_factory_mojo.h View 1 chunk +0 lines, -52 lines 0 comments Download
D mojo/aura/context_factory_mojo.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/aura/window_tree_host_mojo.h View 1 chunk +0 lines, -72 lines 0 comments Download
D mojo/aura/window_tree_host_mojo.cc View 1 chunk +0 lines, -173 lines 0 comments Download
D mojo/examples/launcher/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/examples/launcher/launcher.cc View 1 chunk +0 lines, -291 lines 0 comments Download
D mojo/examples/launcher/launcher.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/examples/sample_view_manager_app/DEPS View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/examples/sample_view_manager_app/sample_view_manager_app.cc View 1 2 3 4 1 chunk +0 lines, -103 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 1 chunk +0 lines, -50 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
M mojo/services/view_manager/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A + mojo/services/view_manager/context_factory_impl.h View 3 chunks +11 lines, -7 lines 0 comments Download
A + mojo/services/view_manager/context_factory_impl.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M mojo/services/view_manager/root_view_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/services/view_manager/window_tree_host_impl.h View 2 chunks +10 lines, -6 lines 0 comments Download
A + mojo/services/view_manager/window_tree_host_impl.cc View 4 chunks +34 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
6 years, 6 months ago (2014-06-05 22:46:27 UTC) #1
Ben Goodger (Google)
lgtm if you remove sample_view_manager_app too
6 years, 6 months ago (2014-06-05 22:53:11 UTC) #2
sky
Done
6 years, 6 months ago (2014-06-05 22:54:08 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-05 22:54:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/315223004/40001
6 years, 6 months ago (2014-06-05 22:55:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 10:34:15 UTC) #6
commit-bot: I haz the power
Failed to apply patch for mojo/mojo_services.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-06 10:34:16 UTC) #7
sky
6 years, 6 months ago (2014-06-06 16:08:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r275453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698