Issue 315223002: DevTools: [JSDoc] Fix invalid @param and @return annotations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 315223002: DevTools: [JSDoc] Fix invalid @param and @return annotations (Closed)

Created:
6 years, 6 months ago by apavlov

Modified:
6 years, 6 months ago

Reviewers:
vsevik, aandrey

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [JSDoc] Fix invalid @param and @return annotations TBR=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175572

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	Source/devtools/front_end/ScreencastView.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/network/NetworkPanel.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sdk/Target.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apavlov

Committed patchset #1 manually as r175572 (presubmit successful).

6 years, 6 months ago (2014-06-05 14:25:17 UTC) #2

apavlov

6 years, 6 months ago (2014-06-05 14:36:48 UTC) #4

Message was sent while issue was closed.

On 2014/06/05 14:35:00, aandrey wrote:
> do we want to add a presubmit check for this?

Care to review https://codereview.chromium.org/315213003/ ? :)

Expand Messages | Collapse Messages