Oilpan: Remove RefPtrs to Node and its subclasses in core/inspector/ with Oilpan transition types.

Source/core/inspector/InspectorDOMAgent.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 158 matching lines @@
     void releaseDanglingNodes();
 
     void domContentLoadedEventFired(LocalFrame*);
     void didCommitLoad(LocalFrame*, DocumentLoader*);
 
     void didInsertDOMNode(Node*);
     void willRemoveDOMNode(Node*);
     void willModifyDOMAttr(Element*, const AtomicString& oldValue, const AtomicString& newValue);
     void didModifyDOMAttr(Element*, const AtomicString& name, const AtomicString& value);
     void didRemoveDOMAttr(Element*, const AtomicString& name);
-    void styleAttributeInvalidated(const Vector<Element*>& elements);
+    void styleAttributeInvalidated(const WillBeHeapVector<RawPtrWillBeMember<Element> >& elements);
     void characterDataModified(CharacterData*);
     void didInvalidateStyleAttr(Node*);
     void didPushShadowRoot(Element* host, ShadowRoot*);
     void willPopShadowRoot(Element* host, ShadowRoot*);
     void frameDocumentUpdated(LocalFrame*);
     void pseudoElementCreated(PseudoElement*);
     void pseudoElementDestroyed(PseudoElement*);
 
     Node* nodeForId(int nodeId);
     int boundNodeId(Node*);
@@ skipping 24 matching lines @@
 
 private:
     enum SearchMode { NotSearching, SearchingForNormal, SearchingForUAShadow };
 
     InspectorDOMAgent(InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*);
 
     void setSearchingForNode(ErrorString*, SearchMode, JSONObject* highlightConfig);
     PassOwnPtr<HighlightConfig> highlightConfigFromInspectorObject(ErrorString*, JSONObject* highlightInspectorObject);
 
     // Node-related methods.
-    typedef HashMap<RefPtr<Node>, int> NodeToIdMap;
+    typedef WillBeHeapHashMap<RefPtrWillBeMember<Node>, int> NodeToIdMap;
     int bind(Node*, NodeToIdMap*);
     void unbind(Node*, NodeToIdMap*);
 
     Node* assertEditableNode(ErrorString*, int nodeId);
     Element* assertEditableElement(ErrorString*, int nodeId);
 
     void inspect(Node*);
 
     int pushNodePathToFrontend(Node*);
     void pushChildNodesToFrontend(int nodeId, int depth = 1);
@@ skipping 16 matching lines @@
 
     void innerHighlightQuad(PassOwnPtr<FloatQuad>, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor);
 
     bool pushDocumentUponHandlelessOperation(ErrorString*);
 
     InspectorPageAgent* m_pageAgent;
     InjectedScriptManager* m_injectedScriptManager;
     InspectorOverlay* m_overlay;
     InspectorFrontend::DOM* m_frontend;
     DOMListener* m_domListener;
-    NodeToIdMap m_documentNodeToIdMap;
+    OwnPtrWillBePersistent<NodeToIdMap> m_documentNodeToIdMap;

[haraken, 2014/06/06 07:17:04]

I'm curious why you need to change this from NodeToIdMap to
OwnPtrWillBePersistent<NodeToIdMap> ?

[tkent, 2014/06/06 07:59:45]

I already explained it in the CL description.

     // Owns node mappings for dangling nodes.
-    Vector<OwnPtr<NodeToIdMap> > m_danglingNodeToIdMaps;
-    HashMap<int, Node*> m_idToNode;
-    HashMap<int, NodeToIdMap*> m_idToNodesMap;
+    WillBePersistentHeapVector<OwnPtrWillBeMember<NodeToIdMap> > m_danglingNodeToIdMaps;
+    WillBePersistentHeapHashMap<int, RawPtrWillBeMember<Node> > m_idToNode;

[haraken, 2014/06/06 07:17:04]

I don't fully understand this map. Are you sure that this is not a weak member
but a member?

[tkent, 2014/06/06 07:59:45]

This mapped Node is always in m_documentNodeToIdMap or m_danglingNodeToIdMaps. 
So, Nodes lifetime should not be changed.

+    WillBePersistentHeapHashMap<int, RawPtrWillBeMember<NodeToIdMap> > m_idToNodesMap;

[haraken, 2014/06/06 07:17:04]

Ditto. I couldn't find code to remove entries from m_idToNodesMap. Not related
to your CL, I wonder why we don't need to remove the entries from m_idToNodesMap
when the InspectorDOMAgent gets unbound (i.e., InspectorDOMAgent::unbind).

[tkent, 2014/06/06 07:59:45]

Hmm, it seems we should clear m_idToNodesMap in
InspectorDOMAgent::discardFrontendBindings.

[yurys, 2014/06/06 08:26:00]

Looks like a bug to me. We should remove corresponding entry in unbind and clear
the map in discardFrontendBindings

[tkent, 2014/06/06 08:26:07]

Done.

     HashSet<int> m_childrenRequested;
     HashMap<int, int> m_cachedChildCount;
     int m_lastNodeId;
-    RefPtr<Document> m_document;
-    typedef HashMap<String, Vector<RefPtr<Node> > > SearchResults;
+    RefPtrWillBePersistent<Document> m_document;
+    typedef WillBePersistentHeapHashMap<String, WillBeHeapVector<RefPtrWillBeMember<Node> > > SearchResults;
     SearchResults m_searchResults;
     OwnPtr<RevalidateStyleAttributeTask> m_revalidateStyleAttrTask;
     SearchMode m_searchingForNode;
     OwnPtr<HighlightConfig> m_inspectModeHighlightConfig;
     OwnPtr<InspectorHistory> m_history;
     OwnPtr<DOMEditor> m_domEditor;
     bool m_suppressAttributeModifiedEvent;
     Listener* m_listener;
 };
 
 
 } // namespace WebCore
 
 #endif // !defined(InspectorDOMAgent_h)