Fix definition of INTPTR_{MIN,MAX} in stdint.h

Fix definition of INTPTR_{MIN,MAX} in stdint.h

The newlib headers currently check for __INTPTR_TYPE__ and assume it
means that __INTPTR_MAX__ is defined.

This is true for newer versions of GCC, but it is not true for
pnacl-clang 3.4 (__INTPTR_TYPE__ is defined, but __INTPTR_{MIN,MAX}__
are not).

BUG=none
R=mcgrathr@chromium.org
TEST=built pnacl toolchain locally

Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=c063c56

[Roland McGrath, 2014-06-05 18:54:27]

LGTM but please follow up with newlib upstream to merge the change there, and/or
with clang folks to fix clang.

[Mark Seaborn, 2014-06-05 18:55:13]

On 5 June 2014 11:49, <binji@chromium.org> wrote:

> Reviewers: Roland McGrath,
>
> Description:
> Fix definition of INTPTR_{MIN,MAX} in stdint.h
>
> The newlib headers currently check for __INTPTR_TYPE__ and assume it
> means that __INTPTR_MAX__ is defined.
>
> This is true for newer versions of GCC, but it is not true for
> pnacl-clang 3.4 (__INTPTR_TYPE__ is defined, but __INTPTR_{MIN,MAX}__
> are not).


FWIW, it would be better to fix that in Clang rather than in newlib.  Then
this will work regardless of which libc we use.  I don't object to making
this change in newlib, though.

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/d/optout.

[binji, 2014-06-05 20:47:46]

Committed patchset #1 manually as rc063c56 (presubmit successful).