Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 315213003: DevTools: [JsDocValidator] Check validity of @param and @return annotations (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/MethodAnnotationChecker.java ('K') | « Source/devtools/scripts/jsdoc-validator/tests/function.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:1: ERROR - @return annotation is requi red for API functions that return value 1 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:1: ERROR - @return annotation is requi red for API functions that return value
2 function badFuncNoAnnotation() { 2 function badFuncNoAnnotation() {
3 ^ 3 ^
4 4
5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:8: ERROR - @return annotation found, y et function does not return value 5 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:8: ERROR - @return annotation found, y et function does not return value
6 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation. 6 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation.
7 ^ 7 ^
8 8
9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:15: ERROR - @return annotation found, yet function does not return value 9 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:15: ERROR - @return annotation found, yet function does not return value
10 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value. 10 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value.
11 ^ 11 ^
12 12
13 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:29: ERROR - invalid @returns annotatio n found - should be @return instead 13 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:29: ERROR - invalid return type annota tion found - should be "@return {<type>}"
14 * @returns {number} 14 * @returns {number}
15 ^ 15 ^
16 16
17 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:37: ERROR - invalid @returns annotatio n found - please remove, as function does not return value 17 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:37: ERROR - invalid return type annota tion found - should be "@return {<type>}"
18 * @return number
19 ^
20
21 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:45: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName"
22 * @param number foo
23 ^
24
25 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:46: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName"
26 * @param bar
27 ^
28
29 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:48: ERROR - @return annotation is requ ired for API functions that return value
30 function badParamAnnotationsFunc(foo, bar) // ERROR - @param's should be well-fo rmed
31 ^
32
33 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:55: ERROR - invalid return type annota tion found - please remove, as function does not return value
18 * @returns {number} 34 * @returns {number}
19 ^ 35 ^
20 36
21 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:45: ERROR - invalid @returns annotatio n found - please remove, as function does not return value 37 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:63: ERROR - invalid return type annota tion found - please remove, as function does not return value
22 * @returns {number} 38 * @returns {number}
23 ^ 39 ^
24 40
25 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:62: ERROR - @return annotation is requ ired for API functions that return value 41 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:80: ERROR - @return annotation is requ ired for API functions that return value
26 badApiMethodNoAnnotation: function() // ERROR - public method. 42 badApiMethodNoAnnotation: function() // ERROR - public method.
27 ^ 43 ^
28 44
29 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:91: ERROR - @return annotation found, yet function does not return value 45 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:109: ERROR - @return annotation found, yet function does not return value
30 badMethodDoesNotReturnValue: function() // ERROR - does not return value. 46 badMethodDoesNotReturnValue: function() // ERROR - does not return value.
31 ^ 47 ^
32 48
33 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:99: ERROR - @return annotation found, yet function does not return value 49 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:117: ERROR - @return annotation found, yet function does not return value
34 badMethodDoesNotReturn: function() // ERROR - does not return. 50 badMethodDoesNotReturn: function() // ERROR - does not return.
35 ^ 51 ^
36 52
37 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:105: ERROR - invalid @returns annotati on found - should be @return instead 53 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:123: ERROR - invalid return type annot ation found - should be "@return {<type>}"
38 * @returns {number} 54 * @returns {number}
39 ^ 55 ^
40 56
41 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:113: ERROR - invalid @returns annotati on found - please remove, as function does not return value 57 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:131: ERROR - invalid return type annot ation found - please remove, as function does not return value
42 * @returns {number} 58 * @returns {number}
43 ^ 59 ^
44 60
45 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:121: ERROR - invalid @returns annotati on found - please remove, as function does not return value 61 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:139: ERROR - invalid return type annot ation found - please remove, as function does not return value
46 * @returns {number} 62 * @returns {number}
47 ^ 63 ^
48 64
49 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:141: ERROR - @return annotation is req uired for API functions that return value 65 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:159: ERROR - @return annotation is req uired for API functions that return value
50 badApiMethodNoAnnotation: function() // ERROR - public method. 66 badApiMethodNoAnnotation: function() // ERROR - public method.
51 ^ 67 ^
52 68
53 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:162: ERROR - @return annotation found, yet function does not return value 69 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:180: ERROR - @return annotation found, yet function does not return value
54 badMethodDoesNotReturnValue: function() // ERROR - does not return value. 70 badMethodDoesNotReturnValue: function() // ERROR - does not return value.
55 ^ 71 ^
56 72
57 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:170: ERROR - @return annotation found, yet function does not return value 73 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:188: ERROR - @return annotation found, yet function does not return value
58 badMethodDoesNotReturn: function() // ERROR - does not return. 74 badMethodDoesNotReturn: function() // ERROR - does not return.
59 ^ 75 ^
60 76
61 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:176: ERROR - invalid @returns annotati on found - should be @return instead 77 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:194: ERROR - invalid return type annot ation found - should be "@return {<type>}"
62 * @returns {number} 78 * @returns {number}
63 ^ 79 ^
64 80
65 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:184: ERROR - invalid @returns annotati on found - please remove, as function does not return value 81 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:202: ERROR - invalid return type annot ation found - please remove, as function does not return value
66 * @returns {number} 82 * @returns {number}
67 ^ 83 ^
68 84
69 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:192: ERROR - invalid @returns annotati on found - please remove, as function does not return value 85 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:210: ERROR - invalid return type annot ation found - please remove, as function does not return value
70 * @returns {number} 86 * @returns {number}
71 ^ 87 ^
72 88
73 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:212: ERROR - invalid @returns annotati on found - should be @return instead 89 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:230: ERROR - invalid return type annot ation found - should be "@return {<type>}"
74 * @returns {number} 90 * @returns {number}
75 ^ 91 ^
76 92
77 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:233: ERROR - @return annotation is req uired for API functions that return value 93 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:251: ERROR - @return annotation is req uired for API functions that return value
78 badApiMethodNoAnnotation: function() // ERROR - public method. 94 badApiMethodNoAnnotation: function() // ERROR - public method.
79 ^ 95 ^
80 96
81 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:254: ERROR - @return annotation found, yet function does not return value 97 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:272: ERROR - @return annotation found, yet function does not return value
82 badMethodDoesNotReturnValue: function() // ERROR - does not return value. 98 badMethodDoesNotReturnValue: function() // ERROR - does not return value.
83 ^ 99 ^
84 100
85 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:262: ERROR - @return annotation found, yet function does not return value 101 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:280: ERROR - @return annotation found, yet function does not return value
86 badMethodDoesNotReturn: function() // ERROR - does not return. 102 badMethodDoesNotReturn: function() // ERROR - does not return.
87 ^ 103 ^
88 104
89 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:268: ERROR - invalid @returns annotati on found - should be @return instead 105 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:286: ERROR - invalid return type annot ation found - should be "@return {<type>}"
90 * @returns {number} 106 * @returns {number}
91 ^ 107 ^
92 108
93 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:276: ERROR - invalid @returns annotati on found - please remove, as function does not return value 109 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:294: ERROR - invalid return type annot ation found - should be "@return {<type>}"
110 * @returns number
111 ^
112
113 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:302: ERROR - invalid return type annot ation found - please remove, as function does not return value
94 * @returns {number} 114 * @returns {number}
95 ^ 115 ^
96 116
97 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:284: ERROR - invalid @returns annotati on found - please remove, as function does not return value 117 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:310: ERROR - invalid return type annot ation found - please remove, as function does not return value
98 * @returns {number} 118 * @returns {number}
99 ^ 119 ^
100 120
101 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:305: ERROR - No @param JSDoc tag found for parameters: [b] 121 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:318: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName"
122 * @param number foo
123 ^
124
125 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:319: ERROR - Invalid @param annotation found - should be "@param {<type>} paramName"
126 * @param bar
127 ^
128
129 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:321: ERROR - @return annotation is req uired for API functions that return value
130 badMethodParamAnnotations: function(foo, bar) // ERROR - @param's should be well-formed
131 ^
132
133 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:340: ERROR - No @param JSDoc tag found for parameters: [b]
102 /** 134 /**
103 ^ 135 ^
104 136
105 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:311: ERROR - No @param JSDoc tag found for parameters: [b,c] 137 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/function.js:346: ERROR - No @param JSDoc tag found for parameters: [b,c]
106 /** 138 /**
107 ^ 139 ^
108 140
109 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends 141 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:8: ERROR - No __proto__ assigned for type DerivedNoProto having @extends
110 * @extends {Base} 142 * @extends {Base}
111 ^ 143 ^
112 144
113 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor 145 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/proto.js:10: ERROR - Type DerivedNoProto extends B ase but does not properly invoke its constructor
114 DerivedNoProto = function() {} 146 DerivedNoProto = function() {}
115 ^ 147 ^
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 ^ 319 ^
288 320
289 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:268: ERROR - @this annotation is required for functions referencing 'this' 321 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:268: ERROR - @this annotation is required for functions referencing 'this'
290 function callbackReferencingThisNotAnnotated() 322 function callbackReferencingThisNotAnnotated()
291 ^ 323 ^
292 324
293 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:277: ERROR - @this annotation found for fu nction not referencing 'this' 325 /usr/local/google/home/apavlov/dev/blink/src/third_party/WebKit/Source/devtools/ scripts/jsdoc-validator/tests/this.js:277: ERROR - @this annotation found for fu nction not referencing 'this'
294 function callbackNotReferencingThisAnnotated() 326 function callbackNotReferencingThisAnnotated()
295 ^ 327 ^
296 328
297 Total errors: 74 329 Total errors: 82
OLDNEW
« Source/devtools/scripts/jsdoc-validator/src/org/chromium/devtools/jsdoc/checks/MethodAnnotationChecker.java ('K') | « Source/devtools/scripts/jsdoc-validator/tests/function.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698