Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 315213002: Reset avatar image when the avatar policy becomes unset (Closed)

Created:
6 years, 6 months ago by bartfab (slow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Reset avatar image when the avatar policy becomes unset When the avatar policy is cleared, the user can pick an avatar image again. Until the user does this, Chrome has two options: 1) keep using the image that had most recently been set through policy 2) revert to a default image Chrome's current behavior is (1). This CL changes it to (2), which may be easier to understand for users and is consistent with the behavior of the wallpaper policy. BUG=380422 TEST=Updated browser test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -21 lines) Patch
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 2 chunks +16 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bartfab (slow)
Hi Pavel, Could you take a look at this CL please?
6 years, 6 months ago (2014-06-05 14:05:55 UTC) #1
dzhioev (left Google)
LGTM
6 years, 6 months ago (2014-06-05 17:01:15 UTC) #2
bartfab (slow)
The CQ bit was checked by bartfab@chromium.org
6 years, 6 months ago (2014-06-05 17:05:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/315213002/1
6 years, 6 months ago (2014-06-05 17:06:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 20:05:01 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 01:15:08 UTC) #6
Message was sent while issue was closed.
Change committed as 275289

Powered by Google App Engine
This is Rietveld 408576698