Issue 3152004: make: Fixup variable names for actions and rules....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3152004: make: Fixup variable names for actions and rules.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Evan Martin

Modified:
4 years ago

Reviewers:
Paweł Hajdan Jr.

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

make: Fixup variable names for actions and rules. Action names can contain spaces, which won't work for variable names in a Makefile. Based on a patch from Paweł Hajdan jr <phajdan.jr@chromium.org>;. Committed: http://code.google.com/p/gyp/source/detail?r=840

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	pylib/gyp/generator/make.py	View		3 chunks	+8 lines, -2 lines	0 comments	Download

Trybot results:

Total messages: 1 (0 generated)

LGTM