Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 3152004: make: Fixup variable names for actions and rules.... (Closed)

Created:
10 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

make: Fixup variable names for actions and rules. Action names can contain spaces, which won't work for variable names in a Makefile. Based on a patch from Paweł Hajdan jr <phajdan.jr@chromium.org>;. Committed: http://code.google.com/p/gyp/source/detail?r=840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M pylib/gyp/generator/make.py View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Paweł Hajdan Jr.
10 years, 4 months ago (2010-08-11 00:27:42 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698