Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 315183003: Pull in GYP_LINK_CONCURRENCY=N support. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
borenet, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Pull in GYP_LINK_CONCURRENCY=N support. BUG=skia: Committed: https://skia.googlesource.com/skia/+/1a50651524128c0843575a764185c0c4c5e7ee6e

Patch Set 1 #

Total comments: 3

Patch Set 2 : full hash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
We can now try fiddling with how many things to link at once by setting ...
6 years, 6 months ago (2014-06-06 01:40:39 UTC) #1
borenet
https://codereview.chromium.org/315183003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/315183003/diff/1/DEPS#newcode11 DEPS:11: "third_party/externals/gyp" : "https://chromium.googlesource.com/external/gyp.git@3917682", I think you want 3917682a16d5c19ff3576a8be0ffdb3a332954b1, right? ...
6 years, 6 months ago (2014-06-06 11:42:45 UTC) #2
mtklein
https://codereview.chromium.org/315183003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/315183003/diff/1/DEPS#newcode11 DEPS:11: "third_party/externals/gyp" : "https://chromium.googlesource.com/external/gyp.git@3917682", On 2014/06/06 11:42:45, borenet wrote: > ...
6 years, 6 months ago (2014-06-06 14:02:10 UTC) #3
borenet
LGTM https://codereview.chromium.org/315183003/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/315183003/diff/1/DEPS#newcode11 DEPS:11: "third_party/externals/gyp" : "https://chromium.googlesource.com/external/gyp.git@3917682", On 2014/06/06 14:02:10, mtklein wrote: ...
6 years, 6 months ago (2014-06-06 14:08:32 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-06 14:10:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/315183003/20001
6 years, 6 months ago (2014-06-06 14:11:15 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 14:37:50 UTC) #7
Message was sent while issue was closed.
Change committed as 1a50651524128c0843575a764185c0c4c5e7ee6e

Powered by Google App Engine
This is Rietveld 408576698