Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 315173002: Revert of Remove scoped styles. (Closed)

Created:
6 years, 6 months ago by Peter Beverloo
Modified:
6 years, 6 months ago
Reviewers:
esprehn, tasak, kochi
CC:
darktears, arv+blink, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, hayato, rwlbuis, rune+blink, sof, watchdog-blink-watchlist_google.com, webcomponents-bugzilla_chromium.org
Visibility:
Public.

Description

Revert of Remove scoped styles. (https://codereview.chromium.org/310443002/) Reason for revert: Broke every incremental compile bot on the waterfall: InternalRuntimeFlags.h: In member function 'bool WebCore::InternalRuntimeFlags::styleScopedEnabled()': InternalRuntimeFlags.h:110:40: error: 'styleScopedEnabled' is not a member of 'WebCore::RuntimeEnabledFeatures' bool styleScopedEnabled() { return RuntimeEnabledFeatures::styleScopedEnabled(); } While a clobber build indeed fixes the problem, it also breaks local builds, which increases the cost of this CL significantly. Let's try to find a proper solution in the bug. BUG=381111 Original issue's description: > Remove scoped styles. > > Removes <style scoped>. > > This was discussed and approved with LGTMs in blink-dev: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/R1x18ZLS5qQ/Bjuh_cENhlQJ > > Chrome status dashboard entry: > http://www.chromestatus.com/features/5374137958662144 > > Note: > this is based on esprehn's original cl: > https://codereview.chromium.org/214693002/ > > BUG=379096 > TEST=pass all layout tests > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175555 TBR=esprehn@chromium.org,tasak@google.com,kochi@chromium.org NOTREECHECKS=true NOTRY=true BUG=379096 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2278 lines, -44 lines) Patch
A LayoutTests/fast/css/style-scoped/basic-attribute.html View 1 chunk +122 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/basic-attribute-expected.txt View 1 chunk +62 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/changing-scoped-attribute-asan-crash.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/changing-scoped-attribute-asan-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/registering.html View 1 chunk +142 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/registering-expected.txt View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/registering-shadowroot.html View 1 chunk +70 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/registering-shadowroot-expected.txt View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-attach.html View 1 chunk +70 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-attach-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-basic.html View 1 chunk +88 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-basic-expected.txt View 1 chunk +44 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html View 1 chunk +304 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-change-scoped-in-shadow-expected.txt View 1 chunk +55 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-detach.html View 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-detach-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-in-shadow.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-in-shadow-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-keyframes.html View 1 chunk +60 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-keyframes-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-nested.html View 1 chunk +46 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-nested-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-remove-scoped.html View 1 chunk +77 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-remove-scoped-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-scoping-nodes-different-order.html View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-scoping-nodes-different-order-expected.txt View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-set-scoped.html View 1 chunk +77 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-set-scoped-expected.txt View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-shadow-crash.html View 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-shadow-crash-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-with-dom-operation.html View 1 chunk +52 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-with-dom-operation-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule.html View 1 chunk +83 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/style-scoped/style-scoped-with-important-rule-expected.txt View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-scoped.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/content-pseudo-element-scoped-expected.html View 1 chunk +12 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host.html View 1 chunk +22 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/shadow/shadow-tree-styles-select-host-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/style-scoped-not-enabled.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/style-scoped-not-enabled-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 2 chunks +20 lines, -15 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +11 lines, -4 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleTree.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ContextFeatures.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/ContextFeatures.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 3 chunks +11 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/dom/StyleSheetScopingNodeList.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLStyleElement.h View 2 chunks +26 lines, -0 lines 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 5 chunks +127 lines, -17 lines 0 comments Download
M Source/core/html/HTMLStyleElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Peter Beverloo
Created Revert of Remove scoped styles.
6 years, 6 months ago (2014-06-05 12:10:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/315173002/1
6 years, 6 months ago (2014-06-05 12:11:06 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 12:12:54 UTC) #3
Message was sent while issue was closed.
Change committed as 175561

Powered by Google App Engine
This is Rietveld 408576698