Source/bindings/v8/Dictionary.cpp - Issue 315133004: Enable Oilpan by default in modules/speech/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 315133004: Enable Oilpan by default in modules/speech/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Events aren't on the heap by default yet; adjust member decl. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/Dictionary.cpp

diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp

index b742140269634cda5059470d069ac5cb05131d76..e171893cbf656b041f98bf972e492da106e1b2ad 100644

--- a/Source/bindings/v8/Dictionary.cpp

+++ b/Source/bindings/v8/Dictionary.cpp

@@ -479,7 +479,7 @@ bool Dictionary::get(const String& key, RefPtrWillBeMember<TrackBase>& value) co

return true;

}

-bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionError>& value) const

+bool Dictionary::get(const String& key, Member<SpeechRecognitionError>& value) const

{

v8::Local<v8::Value> v8Value;

if (!getKey(key, v8Value))

@@ -489,7 +489,7 @@ bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionErro

return true;

}

-bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResult>& value) const

+bool Dictionary::get(const String& key, Member<SpeechRecognitionResult>& value) const

{

v8::Local<v8::Value> v8Value;

if (!getKey(key, v8Value))

@@ -499,7 +499,7 @@ bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResu

return true;

}

-bool Dictionary::get(const String& key, RefPtrWillBeMember<SpeechRecognitionResultList>& value) const

+bool Dictionary::get(const String& key, Member<SpeechRecognitionResultList>& value) const

{

v8::Local<v8::Value> v8Value;

if (!getKey(key, v8Value))