Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: Source/modules/speech/SpeechSynthesisVoice.h

Issue 315133004: Enable Oilpan by default in modules/speech/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Events aren't on the heap by default yet; adjust member decl. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 17 matching lines...) Expand all
28 28
29 #include "bindings/v8/ScriptWrappable.h" 29 #include "bindings/v8/ScriptWrappable.h"
30 #include "platform/heap/Handle.h" 30 #include "platform/heap/Handle.h"
31 #include "platform/speech/PlatformSpeechSynthesisVoice.h" 31 #include "platform/speech/PlatformSpeechSynthesisVoice.h"
32 #include "wtf/PassRefPtr.h" 32 #include "wtf/PassRefPtr.h"
33 #include "wtf/RefCounted.h" 33 #include "wtf/RefCounted.h"
34 #include "wtf/text/WTFString.h" 34 #include "wtf/text/WTFString.h"
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 class SpeechSynthesisVoice FINAL : public RefCountedWillBeGarbageCollectedFinali zed<SpeechSynthesisVoice>, public ScriptWrappable { 38 class SpeechSynthesisVoice FINAL : public GarbageCollectedFinalized<SpeechSynthe sisVoice>, public ScriptWrappable {
39 public: 39 public:
40 static PassRefPtrWillBeRawPtr<SpeechSynthesisVoice> create(PassRefPtr<Platfo rmSpeechSynthesisVoice>); 40 static SpeechSynthesisVoice* create(PassRefPtr<PlatformSpeechSynthesisVoice> );
41 41
42 const String& voiceURI() const { return m_platformVoice->voiceURI(); } 42 const String& voiceURI() const { return m_platformVoice->voiceURI(); }
43 const String& name() const { return m_platformVoice->name(); } 43 const String& name() const { return m_platformVoice->name(); }
44 const String& lang() const { return m_platformVoice->lang(); } 44 const String& lang() const { return m_platformVoice->lang(); }
45 bool localService() const { return m_platformVoice->localService(); } 45 bool localService() const { return m_platformVoice->localService(); }
46 bool isDefault() const { return m_platformVoice->isDefault(); } 46 bool isDefault() const { return m_platformVoice->isDefault(); }
47 47
48 PlatformSpeechSynthesisVoice* platformVoice() const { return m_platformVoice .get(); } 48 PlatformSpeechSynthesisVoice* platformVoice() const { return m_platformVoice .get(); }
49 49
50 void trace(Visitor*) { } 50 void trace(Visitor*) { }
51 51
52 private: 52 private:
53 explicit SpeechSynthesisVoice(PassRefPtr<PlatformSpeechSynthesisVoice>); 53 explicit SpeechSynthesisVoice(PassRefPtr<PlatformSpeechSynthesisVoice>);
54 54
55 RefPtr<PlatformSpeechSynthesisVoice> m_platformVoice; 55 RefPtr<PlatformSpeechSynthesisVoice> m_platformVoice;
haraken 2014/06/05 14:30:28 Nit: You might want to move this to the heap in a
sof 2014/06/05 16:30:43 Thanks. I simply assumed (based on its name) this
56 }; 56 };
57 57
58 } // namespace WebCore 58 } // namespace WebCore
59 59
60 #endif // SpeechSynthesisVoice_h 60 #endif // SpeechSynthesisVoice_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698