Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 31513002: dbus: Remove MockShillDeviceClient and MockShillIPConfigClient (Closed)

Created:
7 years, 2 months ago by satorux1
Modified:
7 years, 2 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

dbus: Remove MockShillDeviceClient and MockShillIPConfigClient These are not in use. Along the way rename ShillDeviceClientStub to FakeShillDeviceClient and ShillIPConfigClient to FakeShillIPConfigClient respectively. BUG=234463, 309506 TEST=none R=hashimoto@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229744

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comments #

Patch Set 3 : fix the build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -797 lines) Patch
M chromeos/chromeos.gyp View 4 chunks +4 lines, -10 lines 0 comments Download
M chromeos/dbus/fake_shill_device_client.h View 1 2 2 chunks +45 lines, -6 lines 0 comments Download
M chromeos/dbus/fake_shill_device_client.cc View 1 5 chunks +201 lines, -6 lines 0 comments Download
A + chromeos/dbus/fake_shill_ipconfig_client.h View 2 chunks +11 lines, -10 lines 0 comments Download
A + chromeos/dbus/fake_shill_ipconfig_client.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.h View 3 chunks +12 lines, -12 lines 0 comments Download
M chromeos/dbus/mock_dbus_thread_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
D chromeos/dbus/mock_shill_device_client.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chromeos/dbus/mock_shill_device_client.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chromeos/dbus/mock_shill_ipconfig_client.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chromeos/dbus/mock_shill_ipconfig_client.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chromeos/dbus/shill_device_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chromeos/dbus/shill_device_client_stub.h View 1 chunk +0 lines, -121 lines 0 comments Download
D chromeos/dbus/shill_device_client_stub.cc View 1 chunk +0 lines, -300 lines 0 comments Download
M chromeos/dbus/shill_ipconfig_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chromeos/dbus/shill_ipconfig_client_stub.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chromeos/dbus/shill_ipconfig_client_stub.cc View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
7 years, 2 months ago (2013-10-21 03:17:39 UTC) #1
satorux1
https://codereview.chromium.org/31513002/diff/1/chromeos/dbus/fake_shill_device_client.cc File chromeos/dbus/fake_shill_device_client.cc (right): https://codereview.chromium.org/31513002/diff/1/chromeos/dbus/fake_shill_device_client.cc#newcode1 chromeos/dbus/fake_shill_device_client.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
7 years, 2 months ago (2013-10-21 03:19:03 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/31513002/diff/1/chromeos/dbus/fake_shill_device_client.cc File chromeos/dbus/fake_shill_device_client.cc (right): https://codereview.chromium.org/31513002/diff/1/chromeos/dbus/fake_shill_device_client.cc#newcode256 chromeos/dbus/fake_shill_device_client.cc:256: base::Bind(callback, status)); nit: indent.
7 years, 2 months ago (2013-10-21 04:00:27 UTC) #3
satorux1
https://codereview.chromium.org/31513002/diff/1/chromeos/dbus/fake_shill_device_client.cc File chromeos/dbus/fake_shill_device_client.cc (right): https://codereview.chromium.org/31513002/diff/1/chromeos/dbus/fake_shill_device_client.cc#newcode256 chromeos/dbus/fake_shill_device_client.cc:256: base::Bind(callback, status)); On 2013/10/21 04:00:28, hashimoto wrote: > nit: ...
7 years, 2 months ago (2013-10-21 04:13:21 UTC) #4
satorux1
7 years, 2 months ago (2013-10-21 05:41:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r229744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698