Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 315113002: Test that cookies set by document.cookie are sent in a WebSocket handshake. (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
Adam Rice
CC:
blink-reviews
Visibility:
Public.

Description

Test that cookies set by document.cookie are sent in a WebSocket handshake. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175548

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
A LayoutTests/http/tests/websocket/cookie-document-to-ws.html View 1 chunk +36 lines, -0 lines 2 comments Download
A + LayoutTests/http/tests/websocket/cookie-document-to-ws-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-05 03:32:40 UTC) #1
Adam Rice
https://codereview.chromium.org/315113002/diff/1/LayoutTests/http/tests/websocket/cookie-document-to-ws.html File LayoutTests/http/tests/websocket/cookie-document-to-ws.html (right): https://codereview.chromium.org/315113002/diff/1/LayoutTests/http/tests/websocket/cookie-document-to-ws.html#newcode27 LayoutTests/http/tests/websocket/cookie-document-to-ws.html:27: document.cookie = cookie_id + '=1; Path=/echo-cookie; Max-Age=0'; If the ...
6 years, 6 months ago (2014-06-05 03:47:50 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/315113002/diff/1/LayoutTests/http/tests/websocket/cookie-document-to-ws.html File LayoutTests/http/tests/websocket/cookie-document-to-ws.html (right): https://codereview.chromium.org/315113002/diff/1/LayoutTests/http/tests/websocket/cookie-document-to-ws.html#newcode27 LayoutTests/http/tests/websocket/cookie-document-to-ws.html:27: document.cookie = cookie_id + '=1; Path=/echo-cookie; Max-Age=0'; On 2014/06/05 ...
6 years, 6 months ago (2014-06-05 05:11:11 UTC) #3
Adam Rice
lgtm
6 years, 6 months ago (2014-06-05 05:15:20 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-05 05:49:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/315113002/1
6 years, 6 months ago (2014-06-05 05:50:55 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 06:52:17 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 07:50:52 UTC) #8
Message was sent while issue was closed.
Change committed as 175548

Powered by Google App Engine
This is Rietveld 408576698